Select/More for rests is broken
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project
OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.0.0, revision: 3fdfab3
1) Load this test file: rests selection.mscz
(With Ctrl + A, you can see the rests in different voices)
2) Right-click on a rest -> Select -> More
First observation: the "same subtype" box, for rest so, is greyed
And the result is: all selection fails by ticking, "Same staff", "Same voice", "Same system", "In selection", etc.
An exception: "Same duration" works.
Comments
I'm glad same duration works, because that's what I implemented in https://github.com/musescore/MuseScore/pull/3874 - although I'd be surprised if it's a direct affect of that PR. I'll take a look at this issue.
Edit: turns out I caused the problem :/ it's an easy fix though
https://github.com/musescore/MuseScore/pull/4127
Fixed in branch master, commit 8a9d2fa050
fix #277912: select/more for rests broken
With this fix, if duration is not checked, then the value will be set to - 1 (an impossible duration value). When matching rests, if duration is -1 then duration as a term for matching is skipped and ignored.
Fixed in branch master, commit 6ba431b68d
Merge pull request #4127 from jthistle/277912-select-for-rests-broken
fix #277912: select/more for rests broken
Right-click on a rest -> Select -> All Similar Elements (in Same Staff)
Does select nothing.
In reply to Right-click on a rest ->… by tobik
Works here in Same staff. Not in Range Selection.
See: #278466: Select rests in Range Selection no longer works
In reply to Works here in Same staff… by cadiz1
Hmm - no range selection involved for me.
This selects all four rests for you?
Are you both using latest master? Worked fine for me...
In reply to Hmm - no range selection… by tobik
You talk about all similar elements in same staff previously.
![test.jpg]( "test.jpg")
Now, with this new scenario, it works also as expected here (release build; 6ba431b)
In reply to You talk about all similar… by cadiz1
"Are you both using latest master?"
Of course here, I use the latest revision: 6ba431b, and release build (Windows)
Right now, the problem is, as explained in another issue, when doing (in a Range selection): right-click -> Select all similar elements in range selection.
In reply to Of course, I use the latest… by cadiz1
Weird, my fix should fix it completely :/
I'll take a look at fixing your new issue when I can.
OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.0.0, revision: 75818b6
In reply to OS: Windows 10 (10.0), Arch… by tobik
And so, please try with the latest revision ie: 6ba431b
Oups, this is the version I got pointed to by the automatic update some minutes ago!? But at first I checked with a current self build.
Pls standby, will recheck with revision: 6ba431b
OK - for me it works. Thank you both.
Sorry, its me again. I asked myself why it does work in 6ba431b but not in my current self build.
To get it work in the self build, I have to add
pattern.durationTicks = -1;in score.cpp line 3112 (Score::selectSimilar(..)) and Score::selectSimilarInRange
So is it just incidence or because of different optimization settings? Anyway, in my opinion this line should be added.
Automatically closed -- issue fixed for 2 weeks with no activity.