[1.2] Lines palette broken in revision 5311

• Feb 11, 2012 - 09:28
Type
Functional
Severity
S2 - Critical
Status
closed
Project

The "Lines" palette is broken as of yesterday, see attached snapshot.

Attachment Size
BrokenLinesPalette.png 58.46 KB

Comments

Did check (clean SVN checkout of r5312 and full build): no luck. I now get a crash when opening the lines palette.

GDB output:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb4b4eb30 (LWP 15994)]
0x08284b33 in SlurSegment::layout (this=0x8f27240, p1=@0xbfc17db8, p2=@0xbfc17da8, b=-10)
at /home/lvi/mscore-0-9-6/mscore/mscore/slur.cpp:357
357 slurTie()->startElement()->tick(), slurTie()->endElement()->tick());

If I revert your change in slur.cpp (put the "setLen(_spatium * 7);" back in), I get the behaviour as reported previously.

Ok. Thanks for looking into it. It's due to the fact that your palette is not the default one but loaded from mscore-palette.xml in your config directory. I will dig itnto it and make a fix.

Status (old) fixed needs info

Updated to revision 5322. Result:

Opening the line palette does not crash anymore, but the palette still shows the behaviour documented in the attached PNG file. Furthermore, MusicXML regression testfiles testLines1.xml and testLines2.xml now cause a segfault when imported.

r5323 fixes the crash when loading testLines1.xml and testLines2.xml. Problem was that the implementation of Spanners had changed. After creation they do not have a SpannerSegment any more (this was a hack to support lines in palettes which had ill side effects).
I cannot reproduce the strange lines in the palette. Please try resetting the palette to default. If you are loading an old palette file the "len" property may be missing for spanners.

r5324 fixes the crash when loading testLines1.xml and testLines2.xml in the branch. I can't reproduce the behavior for the palette. Can you share you mscore-palette.xml file?