diatonic transposition of Cb & Cbb is off by an octave

• Aug 2, 2013 - 16:41
Type
Functional
Severity
S4 - Minor
Status
closed
Project
MuseScore

See http://musescore.org/de/node/22113#comment-83677 for a sample score and a PDF describing the issue.

It seems that whole notes with a (additional, i.e. on top of the ones from the key sig) b-accidental on ledger lines gets transposed an octave to much when transposing diatonically.
shorter notes, whole notes not on ledger lines, and notes with a #-accidental are not affected.

d5997be

This might somehow be related to #21190: Ledger lines appear incorrectly positioned for whole notes or values over.

Comments

• Dec 16, 2013 - 04:50
Status (old) active ⇒ patch (code needs review)

I think the original problem describe misses the point a bit. It doesn't have anything to do with length of note, ledger lines, or key. It's just Cb, period - the code for transposing that TPC value diatonically doesn't work right under any circumstances. Same with Cbb.

I've implemented a rather inelegant fix - special casing those two TPC values:

https://github.com/MarcSabatella/MuseScore/commit/4554f23b18d705c1955b1…

I hesitate to submit a PR as I feel there must be a better way to do this.

Reply

• Dec 16, 2013 - 04:56
Title transposing whole notes with a 'b' accidental on ledger lines diatonically is off by an octave ⇒ diatonic transposition of Cb & Cbb is off by an octave

Reply