Ledger lines appear incorrectly positioned for whole notes or values over

• May 23, 2013 - 14:53
Type
Functional
Severity
S4 - Minor
Status
closed
Project
MuseScore

1. Open attached score (produced in 1.3).

Result: Ledger lines are incorrectly positioned.

Ledger lines appear incorrectly positioned for whole notes or values over.png

Note: It happens if the note is a semi-breve, or higher.

Using MuseScore 2.0 Nightly Build (0326f57) - Mac 10.7.5.

Attachment Size
Ledger lines appear incorrectly positioned for whole notes or values over.mscz 1.67 KB
Ledger lines appear incorrectly positioned for whole notes or values over.png 52.5 KB

Comments

• Aug 1, 2013 - 23:38
Status (old) closed ⇒ active

Need to re-open.
Context: commit 7c059a6bc (2013-07-31)

Some recent development broke this again, probably the move of whole notes to be centred in chord, rather than left-aligned and right-hanging, as before (a sample score is attached):
NOT FOUND: 1

Things get even more funny when whole notes are mixed with quarter notes via multiple voices:
NOT FOUND: 2

I think this is related with two facts:

1) ledger line x-position is computed relatively to the chord stem x-pos (see function Chord::layoutPitched() in chord.cpp, line 1577)

2) the stem x-position seems to ignore the note head width.

Food for thought: I see two solutions:

A) The ledger line x-position is computed on note head x-pos, rather than on the stem x-pos

B) The ledger lines are computed segment-wide, rather than chord-wide, taking into account all the note head widths in a given ChordRest segment.

Thanks,

M.

Attachment Size
test_whole_ledger_1.png 3.04 KB
test_whole_ledger_2.png 4.2 KB
test_whole_ledger.mscx 4.04 KB

Reply

• Aug 2, 2013 - 00:35
Status (old) active ⇒ patch (code needs review)

Fix posted on github: https://github.com/musescore/MuseScore/pull/428

I implemented neither of the soluzions quoted above, but I rather tried to compute the right stem x-position for the actual value of chord notes. The result looks like this:
NOT FOUND: 1

I hope the shorter ledger line for the crochet C in the last bar be correct; I'm rather sure a line as wide as the line below (for the semibreve A) would look too wide.

M.

Attachment Size
test_whole_ledger_3.png 4.3 KB

Reply

• Aug 2, 2013 - 01:36

I'm not sure if I can see anything in 'Behind Bars' about this.

Despite the different placement of the note heads, I think LilyPond 2.16.1-1 and Finale 2012.3.r13 seem to agree with you about the crotchet C.

On the other hand, there is an example in bar 9 of 'Original' here . It is a minim, however and I'm not sure about the size of the semibreve, but what do you think?

I can maybe try to find some more published examples generally.

The attached mscz was produced in 1.3.

Attachment Size
Ledger lines.mscz 1.44 KB
LilyPond.png 22.3 KB
Finale.png 487.78 KB

Reply

• Aug 2, 2013 - 10:47

@chen lung:

Thanks for the documentation.

1) Both Lily and Finale use shorter ledger lines for narrower notes and longer lines for wider notes, as my solution does.
However, both left-align the notes, I GREATLY prefer MuseScore solution of centring them.

2) About the example you quote in the other thread (meas. 9 of "Back to the Light"): it is not easy to tell from the scan, but it seems to simply use fixed length ledger lines: the lines for the semibreves are too short and the line for the minim is as long as the lines for the minims in the next measure. If you can look at the original book, you may tell more easily.

Thanks,

M.

Reply

• Aug 13, 2013 - 17:03

I missed the 2. bug in chenlung post.

If I understand correctly, the problem you are hightlighting is that the first half note (C) in treble clef has a too long ledger line? I don't think so, it's the ledger line from the chord above and it feels right to have it longer. We could argue that the notehead is centered on the ledger line in this case. In MuseScore 1.3 and in Sibelius 7 the half note would be left aligned... We could verify is there is a rule somewhere, check Lilypond and Finale and then open a bug report. But it's quite minor, so I will not do it. Feel free to do so.

Reply