Tempo, staff text and other text honored in skipped volta

• Jul 10, 2017 - 11:27
Reported version
2.1
Type
Functional
Severity
S4 - Minor
Status
closed
Project

Test attached score.


Comments

I pushed the wrong #$^%# button.

Came up in https://musescore.org/en/node/231281

Test attached score.

volta bug.mscz

Notice that after the volta the notes are played arco, even though the arco is not encountered during play. This also happens with tempo, swing and I would suspect instrument changes and dynamics. I can't think of any other text that has an impact on playback.

Developer note:
I believe (not verified) this to be related to how the TempoMap is built upon ticks, while perhaps it should be based off of the unwound RepeatList of the score.
Lookup of the effective dynamic has a similar issue as well.

Status fixed

Fixed in branch master, commit b736b8c8ab

fix #231711: Tempo, staff text and other text honored in skipped volta

Volta stores tempo, velocity and channel at the tick before volta and sets it at the last tick of volta

velosity and channel is set inside Score::renderMidi. But tempo is set inside volta::layoutSystem because we need set tempo here because all tempos of score are set in layout. So fermata in seconda volta works correct because fermata apply itself tempo during layouting