Sub-beam of flipped notes incorrectly placed after adding horizontal frame mid-system

• Nov 3, 2013 - 11:03
Type
Functional
Severity
S4 - Minor
Status
closed
Project
Tags

Hello,

When i put an horizontal frame, beam are in wrong format for one line.

When you load attached file, beam are correct but if you add a tie between B and E in Measure 5 or do anything modification, beam are wrong.

Robert

Attachment Size
Test.mscz 1.47 KB

Comments

The 'mis-beaming' occurs only if the horizontal frame is mid-system and if the notes are flipped ('X'); if the frame is at the beginning or end of a system or if the notes are not flipped, beaming is correct.

Hoping this helps to diagnose the issue...

M.

UPDATE:

The issue originates in function Beam::layout2() (file libmscore.beam.cpp) in lines 1578 - 1590 controlled by the test:
    if (c1 && (cr1->up() == cr2->up()))

When there is no mid-staff horiz. frame, the last line
    bl = baseLevel - (beamLevel + 1);
is NOT executed (correctly). When there is a frame, the line IS executed (incorrectly).

The logic of the lines immediately above escapes me (why and how the page position of what is relevant?).

Then I cannot go on, but I think that someone with enough knowledge could fix the issue with realitive ease, at this point.

Thanks,

M.

Title After horizontal frame, beam are wrong Sub-beam of flipped notes incorrectly placed after adding horizontal frame mid-system

Hope the title is better?

Status (old) active patch (code needs review)

Hello,

It's my first contribution with GitHub. I hope i have no make mistake.

Gai-Luron