[Feedback Form] Crash on changing notes after transposition

• Apr 10, 2019 - 17:29
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project

"Ok - I was able to duplicate a crash. Here’s the scenario:
Import midi file.
Hide all instruments except violin.
Select all
Transpose to C
Attempt to move all notes up one step … crash

It is consistently repeatable."

I can reproduce on both 3.0.5 and master:

#0  0x0000000100a90583 in Ms::ScoreElement::isSystem() const at /Users/anatoly-os/Work/MuseScore/libmscore/scoreElement.h:290
#1  0x0000000100cbccf0 in Ms::toSystem(Ms::ScoreElement*) at /Users/anatoly-os/Work/MuseScore/libmscore/scoreElement.h:530
#2  0x0000000100cafb0d in Ms::Beam::system() const at /Users/anatoly-os/Work/MuseScore/libmscore/beam.h:102
#3  0x0000000100cafa39 in Ms::Beam::pagePos() const at /Users/anatoly-os/Work/MuseScore/libmscore/beam.cpp:123
#4  0x0000000100cafb39 in Ms::Beam::canvasPos() const at /Users/anatoly-os/Work/MuseScore/libmscore/beam.cpp:136
#5  0x00000001001460cf in Ms::Element::canvasBoundingRect() const at /Users/anatoly-os/Work/MuseScore/libmscore/element.h:245
#6  0x00000001011b7aa7 in Ms::changeSelection(Ms::Element*, bool) at /Users/anatoly-os/Work/MuseScore/libmscore/select.cpp:287
#7  0x00000001011b7848 in Ms::Selection::clear() at /Users/anatoly-os/Work/MuseScore/libmscore/select.cpp:306
#8  0x0000000100d58e26 in Ms::Score::upDown(bool, Ms::UpDownMode, bool) at /Users/anatoly-os/Work/MuseScore/libmscore/cmd.cpp:1520
#9  0x0000000100d60eaa in Ms::Score::cmdPitchUp() at /Users/anatoly-os/Work/MuseScore/libmscore/cmd.cpp:3063
#10 0x0000000100e24a88 in Ms::Score::cmd(QAction const*, Ms::EditData&)::$_124::operator()() const at /Users/anatoly-os/Work/MuseScore/libmscore/cmd.cpp:3676

P.S.
In debug, the crash happens even earlier when you make instruments invisible one by one and you reach the last one:
mscore/instrwidget.cpp:511 Q_ASSERT(partiturList->currentItem() == item);

Attachment Size
Jenny_on_the_Railroad.mid 135.9 KB

Comments

Yes, and it's not an uncommon scenario at all, I don't mean to suggest the priority be downgraded. But I do think it's already reported, unless it turns out something about this case is different from the other.

Status PR created fixed

Fixed in branch master, commit 88bc651eae

fix #284012: Crash by editing/selecting entire score when another hidden staff contains beamed notes.
fix #287515: Crash on changing notes after transposition.

Fix version
3.1.0