Double-click on drum palette produces wrong note when transposing instrument at top of score and concert pitch off
Reported version
3.2
Priority
P1 - High
Type
Functional
Frequency
Many
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
Yes
Project
1) Add the drum kit to the project
2) Press N and get in to notation mode
3) Double click the options shown in the tab (Clicking it once will play the correct sound but when double clicking one note, a different "note" is written down, for example when i hover over the first option, it says its an acoustic bass drum, click it once, it plays the acoustic bass drum, double click it and it inputs a low tom into the staff)
The only way i could get the correct "note" on the staff was to use the arrow keys to manually scroll through the options.
Fix version
3.5.0
Comments
In order to investigate, we'd need you to attach the score you are having trouble with, also be more specific about which instrument you are adding, also say if you are using the MDL extension. I can't reproduce a problem using the default empty score, adding a Drumset from the basic unpitch percussion, and double clicking the first icon - I got exactly the acoustic bass drum.
In reply to In order to investigate, we… by Marc Sabatella
Oh Im sorry, i tried making a new score and added a drum set and it worked the way it should, it was just a problem in this specific score. I am not using any extensions.
OK, I've figured out the problem and have changed the title accordingly. The problem happens if the top instrument in the score is transposing and concert pitch is off. In that case, double-click apparently tries to transpose the drum palette note for some reason. Other methods of note entry (keyboard shortcut, or click palette then click in score) are fine. Easy workaround for now if you want to sue double-click is turn off concert pitch while entering the drum part.
I'm raising the priority of this because with the new single-click model of palette interaction, this is easier to run into: now you see it on single click (double-click is no longer a thing). So I see it as connected to the larger design of single click in the drum palette.
As discussed on Telegram, I feel we need to step back and look at how single-click works in the drum palette, and possibly go back to the old model, or come up with an improvement - and soon. Fix for this issue may or may not depend on what we do about the design. But I'm guessing since the same bug existed for the old double-click model and the current single click model, the same code might apply and hence the same fix.
see above: turn off concert pitch while entering the drum part
See PR:
https://github.com/musescore/MuseScore/pull/6094
Note:
Currently, by inserting drum notes with double clicks does not preserve those notes voice (e.g. bass drum is entered in voice 1 instead of 2). Is this a known bug?
It's a known behavior, I guess there remains some debate about expected behavior. See for instance #153686: Drum input palette: notes set to enter as voice 2 are entered into voice 1 in error and https://musescore.org/en/node/156161. There definitely needs to be an easy way to override the default voice when needed, and I think most people do like the fact that it's also easy to enter notes into their default voices, but it doesn't really seem like anyone agrees on how to best reconcile these. Some want drum input to work just like standard staves in terms of voices, others the drum input to work in the same way regardless of how you enter the notes., etc. So even though I think we all see there is a problem and that things are inconsistent, I've been unwilling to rock the boat and risk implementing a change that may annoy users who may be relying on the current behavior.
FWIW, I totally support the bug fix for the issue at hand here regarding transposition. But I did want to point out it is no longer quite as critical as it (briefly) was when drum input was somewhat more broken in general (when single-click entered notes).
Fixed in branch 3.x, commit 5329f2bf4d
fix #291522 : Double-click on drum palette produces wrong note when transposing instrument at top of score and concert pitch off
Fixed in branch 3.x, commit 203a57dda0
_Merge pull request #6094 from AntonioBL/palettedrum
fix #291522 : Double-click on drum palette produces wrong note when t…_
needed for master too
Fixed in branch master, commit c4ca6acc1e
_Merge pull request #6094 from AntonioBL/palettedrum
fix #291522 : Double-click on drum palette produces wrong note when t…_
Automatically closed -- issue fixed for 2 weeks with no activity.