Duplicate volta causes later repeats to play wrong

• Oct 20, 2020 - 15:46
Reported version
3.5
Priority
P3 - Low
Type
Functional
Frequency
Few
Severity
S4 - Minor
Reproducibility
Always
Status
fixed
Regression
No
Workaround
Yes
Project

I just updated to the new version, and then suddenly one of the voltas in my sheet didn't work, it was as if it was just a normal repetition. Can't find any way to get it to work again, but at one of my other repetitions, the voltas actually still work.

Bar 28-30 in the file

Attachment Size
Hei hå.mscz 35.23 KB

Comments

Severity S3 - Major S4 - Minor
Priority P3 - Low

Please try the attached score, in which I believe this fixed.

The root cause seems to be that you have an additional 0-length 2nd volta in m17. I've removed that and playback now works.

I'm leaving this report open for a little longer to later be able to use my debugbuild and see if the interpretation logic can better handle such a situation without tripping up.
So far I haven't tested whether the cause is having a superimposed volta (which could happen by accident) or that it is 0-length.

Attachment Size
311986-Hei_hå.mscz 35 KB
Title Voltas not working in some repetitions Duplicate volta causes later repeats to play wrong
Workaround No Yes

The workaround is to delete the unnecessary volta.

I have a similar problem. The first volta (measures 20 and 21) in the attached file repeats correctly on playback but the second volta (measures 37 and 38) plays both measure 37 and 38 on the second time through. I couldn't find a problem with the volta. Help.

Attachment Size
Ngothando.mscz 20.31 KB

In reply to by DaveFlint1

This seems to point that the root cause indeed is the duplication of volta elements, as when removing the technically duplicates on the 2nd-4th instruments, playback is restored.

So definitely a bug in the interpretation of what is currently allowing volta's to be added multiple times.
My only side thought here is that a volta should be a system element, and as such only be allowed to be added once. Then, just for with system text, we should have a mechanism to allow the display of it to be shown on multiple staves within a score, whilst still being just one real element.

Attachment Size
Ngothando-fixed.mscz 20.02 KB

I removed the voltas from the 2nd-4th staves and it plays correctly. I then entered them again using ctrl+click the volta in the palette. This should have fixed the replay problem but it went back playing volta 1 & 2 on the last repeat. I'm stumped. Perhaps @jeetee can look at this and provide some guidance. He may as for a new bug report but I'll let him decide that.

Title Duplicate volta (in non-top staff) causes later repeats to play wrong Duplicate (non-1st) volta (in non-top staff) causes later repeats to play wrong
Title Duplicate (non-1st) volta (in non-top staff) causes later repeats to play wrong Duplicate volta (in non-top staff) causes later repeats to play wrong

Just some developer trace notes for my own benefit.

The duplicate volta causes the "collect"-logic to no longer see the following voltas, they're basically ignored. I think this is because the duplicate volta leads to the logic assuming there are overlapping voltas; a case currently not covered by the logic, which I would've expected to lead to ignoring the current overlap (= the duplicate) but apparently doesn't clean the local tracing stack fully, resulting in volta detection lockup.

Expecting to solve this cleanly within the coming week.

Status PR created fixed

Fixed in branch 3.x, commit 6b43ac8935

Fix #311986: handle duplicate voltas (repeat58)
Also handles overlapping voltas by splitting them into non-overlapping voltas with cross-section repeatlists (test will follow)

Fixed in branch master, commit ef4f173842

Fix #311986: handle duplicate voltas (repeat58)
Fixed initial voltas having the same start crash
Also handles overlapping voltas by splitting them into non-overlapping voltas with cross-section repeatlists

Fix version
3.6.0