Notes entered on a transposing instrument with midi keyboard jump around when not in concert-pitch

• Dec 12, 2014 - 20:58
Type
Graphical (UI)
Severity
S4 - Minor
Status
closed
Project
MuseScore

This happens very visually when you enter a scale in a transposed instrument. The bug is here:
https://github.com/musescore/MuseScore/blob/master/libmscore/cmd.cpp#L1…
It should read:
if (!styleB(StyleIdx::concertPitch)) {
nval.pitch += st->part()->instr(inputState().tick())->transpose().chromatic;
}
nval.tpc1 = pitch2tpc(nval.pitch, key, Prefer::NEAREST);

Comments

• Dec 12, 2014 - 21:25

Sorry, I submitted my report a few minutes before yours :-). Your fix is good, though. I submitted the PR after simplifying even further. We don't actually need to set nva.tpc1 here as the exact same thing is done later in Note::setNval if we leave tpc1 uninitialized here.

Reply