This is for eighth notes, anyhow - sixteenth & shorter notes are handled further down in the code.
It's easy enough to add some code here to enforce a maximum slat of 1sp if there are only two notes on the beam. What I'm not so sure about is what effect that should have on stem lengths. A flatter beam means one or both notes has a different length stem than before. My sense is what makes sense is to keep the shorter note the same length it was and adjust the other to compensate, so that's what I'm looking at.
However, there seems to a bugs here in the stem length calculations, or or the tables that drive them. Certain pairs of notes seem to have unnecessarily short stems - that's before my changes. So I think it important to sort that out. I'm still working on it, but I'm definitely nervous about messing with those tables.
Comments
Also see this: #21726: Grace note beams incorrectly angled
I found where we would need to make the adjustment:
https://github.com/musescore/MuseScore/blob/4fe7cb1e53aa45d0bcd40587b20…
This is for eighth notes, anyhow - sixteenth & shorter notes are handled further down in the code.
It's easy enough to add some code here to enforce a maximum slat of 1sp if there are only two notes on the beam. What I'm not so sure about is what effect that should have on stem lengths. A flatter beam means one or both notes has a different length stem than before. My sense is what makes sense is to keep the shorter note the same length it was and adjust the other to compensate, so that's what I'm looking at.
However, there seems to a bugs here in the stem length calculations, or or the tables that drive them. Certain pairs of notes seem to have unnecessarily short stems - that's before my changes. So I think it important to sort that out. I'm still working on it, but I'm definitely nervous about messing with those tables.
I have what seems to be a working fix - or at least, what I consider an improvement. I just need to do more testing, create some vtests, etc.
https://github.com/musescore/MuseScore/pull/1847
I went with a pretty conservative change, as I know the beam code is delicate. Basically, I limit the slant of two-note beams to 1sp max in all cases.
Fixed in 539ce242c8
Automatically closed -- issue fixed for 2 weeks with no activity.