Better, but still too close to my eyes. #21898: Hyphen collides with lyrics seems fixed though with that commit.
See
taken at 200% zoom and saved with 200DPI
I tried to reproduce the amount of spacing I saw in published scores, which in my experience have very little space as well. Is there a reference you can point to that to suggest there should be more than what I added? Gould doesn't make any specific recommendations, but my spacing seems consistent with what she uses in her examples.
No references, just my personal opinion... (and yes it is minor).
Looking at this in 100% zoom makes it next to impossible to see the tiny gap
Am I interpreting the source right that you've set it to 0.1sp, but use 0.25sp for the lyrics dash?
If so, why not 0.25sp for both?
Edit: I found an example in a published score book that is more pleasing to my eye, I'll try to scan and attach a snippet...
OK, here we go:
Taken from "Band- und Chorbuch zum Gotteslob", Strube Verlag
Not exactly. 0.1sp is the amount of padding added in both cases. It's actually added for hyphens in system.cpp, line 996 in my commit (0.2sp space total, but that's 0.1sp on each side). The 0.25sp figure you are seeing comes from the changes in measures.cpp and layout.cpp, but that is not to create padding. That's to make sure there is enough space between the syllables to create a recognizable hyphen in the first place. Otherwise, with tightly spaced notes, by the time you chop off 0.1sp on each side of the hyphen, it didn't look good.
Regarding the amount of padding before melisma (or around hyphens), ultimately that could be a style parameter along with a whole bunch of other hard-coded values. For now, I'm inclined to leave it as is. It's fairly consistent with Gould, whose melisma lines also start less than a comma-width from the comma. But I'm certainly open to more data.
The published scores I consulted were all over the map, but I did go with something more like the minimum, also looking on what we did in 1.3.
If you want to do some experimentation to find the value you think works best and then submit a PR, I'll take a look and merge a PR. BTW, when using these sort of hard-coded values, I often lean toward nice round multiples of 0.1sp for elements that can be adjusted manually, to make sure the arrow keys can return an element to a good unadjusted position. But that's not an issue here.
Comments
https://github.com/musescore/MuseScore/pull/1595
Fixed in 77e3a87ebf
Better, but still too close to my eyes. #21898: Hyphen collides with lyrics seems fixed though with that commit.
![melisma2.png]( "melisma2.png")
See
taken at 200% zoom and saved with 200DPI
Compare to 2.0 Beta 2, using the same settings:
![melisma1.png]( "melisma1.png")
I tried to reproduce the amount of spacing I saw in published scores, which in my experience have very little space as well. Is there a reference you can point to that to suggest there should be more than what I added? Gould doesn't make any specific recommendations, but my spacing seems consistent with what she uses in her examples.
No references, just my personal opinion... (and yes it is minor).
Looking at this in 100% zoom makes it next to impossible to see the tiny gap
Am I interpreting the source right that you've set it to 0.1sp, but use 0.25sp for the lyrics dash?
If so, why not 0.25sp for both?
Edit: I found an example in a published score book that is more pleasing to my eye, I'll try to scan and attach a snippet...
![sample.png]( "sample.png")
OK, here we go:
Taken from "Band- und Chorbuch zum Gotteslob", Strube Verlag
Not exactly. 0.1sp is the amount of padding added in both cases. It's actually added for hyphens in system.cpp, line 996 in my commit (0.2sp space total, but that's 0.1sp on each side). The 0.25sp figure you are seeing comes from the changes in measures.cpp and layout.cpp, but that is not to create padding. That's to make sure there is enough space between the syllables to create a recognizable hyphen in the first place. Otherwise, with tightly spaced notes, by the time you chop off 0.1sp on each side of the hyphen, it didn't look good.
Regarding the amount of padding before melisma (or around hyphens), ultimately that could be a style parameter along with a whole bunch of other hard-coded values. For now, I'm inclined to leave it as is. It's fairly consistent with Gould, whose melisma lines also start less than a comma-width from the comma. But I'm certainly open to more data.
The published scores I consulted were all over the map, but I did go with something more like the minimum, also looking on what we did in 1.3.
If you want to do some experimentation to find the value you think works best and then submit a PR, I'll take a look and merge a PR. BTW, when using these sort of hard-coded values, I often lean toward nice round multiples of 0.1sp for elements that can be adjusted manually, to make sure the arrow keys can return an element to a good unadjusted position. But that's not an issue here.
I've just tried it with 0.2 for melisma instead of 0.1 (in libmscore/system.cpp, line 890), looks quite OK to me.
See PR #1597
Compare to the images above:
![melisma3.png]( "melisma3.png")
You're right, it's better.
Fixed in 62be8b71ae
Automatically closed -- issue fixed for 2 weeks with no activity.