Changing text color via Inspector doesn't work

Jojo-Schmitz

• Mar 20, 2015 - 07:42

Type

Functional

Severity

S4 - Minor

Status

closed

Project

MuseScore

MuseScore 2.0 RC, Windows 7 (Enterprise, 64bit)

in a score with lyrics select a lyrics syllable (turns blue in RC, as per voice in latest niggtly)
in Inspector change color
unselect

expected result: lyrics syllable shows the color selected
actual result: lyrics syllable remains black
workaround: use right-click, text properties and change color there
Same issue with staff- and system text, tempo text, dynamics, title, subtitle, etc.

Also with chord symbols, but there the workaround doesn't work, as they don't have text properties

This issue came up on IC this morning

Comments

Jojo-Schmitz

• Mar 20, 2015 - 08:28

I think this issue is much older that RC...

See also #22251: Instrument name color not working, there too the workaround wouldn't work

See also #47926: [MuseScore 2.0][Plugin Development] Text coloring via qml does not seem to work, where plugins don't have proper access to that propertiy

Jojo-Schmitz

• Mar 20, 2015 - 08:30

After having change color via Inspector, selecting that element again Inspector shows the changed color (but the element does not)

[DELETED] 5

• Mar 20, 2015 - 09:48

I have a possible fix here https://github.com/musescore/MuseScore/pull/1906
But I'm a bit reluctant to do this now... Tests are welcome...
git checkout -b lasconic-51526-text-color master git pull https://github.com/lasconic/MuseScore.git 51526-text-color

Jojo-Schmitz

• Mar 20, 2015 - 10:45

testing...
Anything in particular?

[DELETED] 5

• Mar 20, 2015 - 11:18

Text properties color and inspector color should now be in sync. Reset to style should reset to the style color. Other elements (non text) color management shouldn't be impacted by this change. It's possible that it fixes the problem with plugins too.
I'm concerned about possible regressions with 1.3 scores or in weird behavior regarding the color of non text element.

Jojo-Schmitz

• Mar 20, 2015 - 11:49

Seems to work fine, so far I couldn't get it to break ;-)
Also tested with 1.3 files, with and without colors, no problem.

One quirk: on a volta (and hairpin) the inspector shows color for element and for line, only changes to the latter take effect, the former seems to get ignored (but recorded, as inspector shows).
Guess the question here is why having _color (for any Element) and _lineColor (for SLine, i.e. Hairpin, Trill and TextLine)

Jojo-Schmitz

• Mar 20, 2015 - 11:22

Status (old)

active

⇒

patch (code needs review)

see https://github.com/musescore/MuseScore/pull/1906

ABL

• Mar 20, 2015 - 13:56

In the case of text line, the _linecolor affects only the line, while the text is affected only by
right click->Line properties...->"..."(text menu of the shown text)->Color.
The "Element" color does nothing at the moment.
Different begin/continue/end texts can have different colors with respect to each other. It would be difficult to implement something similar to what lasconic is proposing for texts in the case of text for textlines (which color should be shown and modified by the "Element" color? The line, the begin text, the continue text, the end text?)
Commit 22b2c660

In MuseScore 1.3 there were Line color and text color, accessed similarly, and the same considerations about colors of begin/continue texts.

Note: It seems that begin/continue text color is lost when importing from v1.3 files, see attachment, produced in MuseScore 1.3 (-> different bug?)