Inconsistent alignment of chord name above fretboard
Reported version
3.4
Type
Graphical (UI)
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
When placing a fretboard, the chord name is nicely centered above the fretboard. When selecting left alignment, the left of the bounding boxes both fretboard and chord name are correct:
However, the right alignment uses a strange reference:
This issue was found when looking #293785: Chord symbols jump when user goes into edit mode and will be solved with the same PR.
Fix version
3.5.0
Comments
https://github.com/musescore/MuseScore/pull/5876
Connected: #294890: Spacing for center-aligned chords not honored until second layout?
In reply to Connected: #294890: Spacing… by geetar
Yes, a side effect of the PR is it solves that issue too. I'll adapt both the comment in PR and update #294890: Spacing for center-aligned chords not honored until second layout. Thanks for reporting this.
Fixed in branch master, commit 9946fb7c42
_Fix #293785: Fix #302590: Fix #294890 Chord symbols jump when user goes into edit mode
This commit resolves two issues:
Fix #302590 - Inconsistent alignment of chord name above fretboard
Fix #293785 - Chord symbols jump when user goes into edit mode
Fix #294890 - Spacing for center-aligned chords not honored until second layout
When looking into #293785 it was found that placement of Harmonies above a FretDiagram
was not consistent.
o) Align::HCENTER aligns the horizontal centers of bot Harmony and FretDiagram.
o) Align::RIGHT aligns the right edge of the Harmony roughly to the centrer of the FretDiagram.
o) Align::LEFT aligns the left edge of the Harmony to the left edge of the FretDiagram.
So every alignment uses it own reference. This has been corrected first.
The root cause of #302590 was the difference of bounding box between NORMAL and EDIT mode.
And this was caused because of the different formating between NORMAL and EDIT. In EDIT mode
the horizontal alignment was using both different algorithm and reference. Also the height
of the bounding box where different in EDIT and NORMAL mode
To solve this the bounding box while in EDIT mode
1) is aligned exactly are in NORMAL mode
2) has the same height in both EDIT and NORMAL mode._
Fixed in branch master, commit 9946fb7c42
_Fix #293785: Fix #302590: Fix #294890 Chord symbols jump when user goes into edit mode
This commit resolves two issues:
Fix #302590 - Inconsistent alignment of chord name above fretboard
Fix #293785 - Chord symbols jump when user goes into edit mode
Fix #294890 - Spacing for center-aligned chords not honored until second layout
When looking into #293785 it was found that placement of Harmonies above a FretDiagram
was not consistent.
o) Align::HCENTER aligns the horizontal centers of bot Harmony and FretDiagram.
o) Align::RIGHT aligns the right edge of the Harmony roughly to the centrer of the FretDiagram.
o) Align::LEFT aligns the left edge of the Harmony to the left edge of the FretDiagram.
So every alignment uses it own reference. This has been corrected first.
The root cause of #302590 was the difference of bounding box between NORMAL and EDIT mode.
And this was caused because of the different formating between NORMAL and EDIT. In EDIT mode
the horizontal alignment was using both different algorithm and reference. Also the height
of the bounding box where different in EDIT and NORMAL mode
To solve this the bounding box while in EDIT mode
1) is aligned exactly are in NORMAL mode
2) has the same height in both EDIT and NORMAL mode._
Fixed in branch master, commit 45fd0fae63
_Merge pull request #5876 from njvdberg/issue-293785-jumping-harmonies
Fix #293785: Fix #302590: Fix #294890: Chord symbols jump when user goes into edit…_
Automatically closed -- issue fixed for 2 weeks with no activity.