Chord symbols jump when user goes into edit mode
Reported version
3.2
Priority
P2 - Medium
Type
Functional
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project
MS 2.3.2.
- In MS2 you could double-click on the exact position at which you wanted to edit the chord symbol. In MS3, when you double-click to edit, the cursor position always defaults to the beginning of the chord.
- The chord symbol, like other text, jumps to another position when you go into edit mode, then returns afterwards.
Fix version
3.5.0
Comments
1) I can see. 2) I don't, probably the is some special case involving autoplace where it could fail. We'd need to see your score in order to understand.
Win 7/10.
Re (2). See attached file. The jumping behaviour when going into edit mode seems to depend on the horizontal alignment of the chord symbol. If left-aligned the chord doesn't move. Center-aligned and right-aligned chords jump to the left. And if the chord symbols are close together AP may also cause the symbol to move upwards on editing.
OK, confirmed, the horizontal alignment code doesn't seem to function optimally in chord symbol edit mode (with or without fret diagrams).
I've noticed that if you change the offset for staff text, editing an existing staff text does the same thing, the text box jumps up to the default location while editing the text and then returns where it belongs when you exit edit mode.
The root cause of the jumping chords when entering edit mode is found and I'm working on PR for this. The reason the cursor jumps always to the beginning of the chord is caused by the jumping so this will solved too.
When looking into this I found the alignment of the chord name to the fretboard was not consistent (#302590: Inconsistent alignment of chord name above fretboard). This will be solved with the same PR.
https://github.com/musescore/MuseScore/pull/5876
Fixed in branch master, commit 9946fb7c42
_Fix #293785: Fix #302590: Fix #294890 Chord symbols jump when user goes into edit mode
This commit resolves two issues:
Fix #302590 - Inconsistent alignment of chord name above fretboard
Fix #293785 - Chord symbols jump when user goes into edit mode
Fix #294890 - Spacing for center-aligned chords not honored until second layout
When looking into #293785 it was found that placement of Harmonies above a FretDiagram
was not consistent.
o) Align::HCENTER aligns the horizontal centers of bot Harmony and FretDiagram.
o) Align::RIGHT aligns the right edge of the Harmony roughly to the centrer of the FretDiagram.
o) Align::LEFT aligns the left edge of the Harmony to the left edge of the FretDiagram.
So every alignment uses it own reference. This has been corrected first.
The root cause of #302590 was the difference of bounding box between NORMAL and EDIT mode.
And this was caused because of the different formating between NORMAL and EDIT. In EDIT mode
the horizontal alignment was using both different algorithm and reference. Also the height
of the bounding box where different in EDIT and NORMAL mode
To solve this the bounding box while in EDIT mode
1) is aligned exactly are in NORMAL mode
2) has the same height in both EDIT and NORMAL mode._
Fixed in branch master, commit 9946fb7c42
_Fix #293785: Fix #302590: Fix #294890 Chord symbols jump when user goes into edit mode
This commit resolves two issues:
Fix #302590 - Inconsistent alignment of chord name above fretboard
Fix #293785 - Chord symbols jump when user goes into edit mode
Fix #294890 - Spacing for center-aligned chords not honored until second layout
When looking into #293785 it was found that placement of Harmonies above a FretDiagram
was not consistent.
o) Align::HCENTER aligns the horizontal centers of bot Harmony and FretDiagram.
o) Align::RIGHT aligns the right edge of the Harmony roughly to the centrer of the FretDiagram.
o) Align::LEFT aligns the left edge of the Harmony to the left edge of the FretDiagram.
So every alignment uses it own reference. This has been corrected first.
The root cause of #302590 was the difference of bounding box between NORMAL and EDIT mode.
And this was caused because of the different formating between NORMAL and EDIT. In EDIT mode
the horizontal alignment was using both different algorithm and reference. Also the height
of the bounding box where different in EDIT and NORMAL mode
To solve this the bounding box while in EDIT mode
1) is aligned exactly are in NORMAL mode
2) has the same height in both EDIT and NORMAL mode._
Fixed in branch master, commit 45fd0fae63
_Merge pull request #5876 from njvdberg/issue-293785-jumping-harmonies
Fix #293785: Fix #302590: Fix #294890: Chord symbols jump when user goes into edit…_
Automatically closed -- issue fixed for 2 weeks with no activity.