MusicXML: support figured bass

When entering figured bass (CTRL-G) on the lower staff, after completion the box with the figure jumps to the upper staff

please don't highjack unrelated issues...
This here had been fixed more than a year ago in e42fb281
The Problem you're talking about has nothing to do with MusicXML

sorry, will repost the question elsewhere, since bug appeared in MuseScoreNightly of today-2014-03-05-1709-4af604c

Automatically closed -- issue fixed for 2 weeks with no activity.

Some features for figured bass mentioned in the [trunk] article still have not been implemented for MusicXML:

• #3: Figures that change ‘mid-way’ needs to be handled with duration tags
• #4: Extension/continuation lines should distinguish “start”, “continue”, and “stop” – useful because MuseScore displays each type differently

The figured bass entry in the MusicXML 3.0 documentation recommends the following (paraphrased):

• Duration should be used when the figure is shorter than the note, e.g., when a figure changes ‘mid-way’
• Extend should be used when there is an extension line

The current version (Beta 1.0, see below) does the following instead:

• No support for duration information; figures that change ‘mid-way’ are lost
• Extend when the figure is longer than the note; multiple figures with different-length continuation lines are not supported/possible

I should have a patch ready within the next couple weeks.

Version Number: MuseScore 2 Beta 1.0 (revision 1efc609)
Operating System: Mac OS X 10.9.5

Hi Jason

Thanks for posting.

Just to let you know, another beta (2) was released, but most importantly, development has continued since either of these (see this to be up-to-date), which you would generally base any contributions on.

Thanks for the heads-up!

I am following the Git workflow, so don’t worry – I’ve been pulling and rebasing as usual. I just wasn’t sure which version to report, and ended up going with the latest public release on my machine (I should have checked for a newer one first… my bad).

To be clear, the issue persists in the latest version as of writing (Jan 9, commit 83622b0a84).

All the best,
Jason

Jason - FYI, in case you weren't aware - we are gearing up for the official 2.0 release, hopefully in the next couple of months. No firm time frame, but I would venture to say, if you can get it done by the end of January, that would probably increase the likelihood of it making this release.

Hello nice people,

I’ve added in all the features I mentioned earlier – export and import of:

• Extend tags for figured bass extensions that last more than one note, and
• Duration tags for figures that change under a single note

In addition, I also enabled the export and import of the “cross” and “backslash” modifiers as well.

A few things you guys could help me with:

• What kind of test file needs to be included? My changes render the previous test (testFiguredBass2.xml) obsolete.
• Authorship: what is customary for crediting on patches?
• One hiccough: After rebasing on the newest commit on the main branch (0dfcac41bc), my Xcode complains about another, completely unrelated piece of code (effects/freeverb/freeverb.h) and prevents me from building the source entirely. Note that this happens even with a regular clone of the main repo, so I’m pretty sure it’s not something I did.

Thanks!
Jason

There is no PR on GitHub to review.

Don't understand your 2nd question, if you submit a PR and it gets merged, it'll carry your name.
And you need to have signed the CLA, which you have already.

As to your 3rd question, the Mac build is currently broken, indeed not your fault. See also http://musescore.org/en/node/45821.
If you submit a PR, Travis will build it and test it, on Linux.

Thanks! I’ll create the test files once the Mac build is working again, and submit the PR after. In this instance, should I replace testFiguredBass2.xml, since its feature has been superseded?

Regarding the authorship question, I was just wondering whether I needed to add a note somewhere stating that the code has been patched (i.e., that the original author may not be to blame for certain passages of code). I understand Git has “blame” built in, but other groups have insisted I add a few lines at the top detailing the patch anyway.

All the best,
Jason

P.S.: I will leave the “Status” field up to you guys from now on.

@jason those extra lines are not needed

Fixed in 1f70682e0e

Automatically closed -- issue fixed for 2 weeks with no activity.