Adding an end/start repeat barline to score adds an end repeat barline to parts
In a score with parts adding an end/start repeat barline (:||:) to score adds an end repeat barline (:|) to the parts, and vice versa.
Similar with changing an end repeat barline to an end/start repeat barline, it only changes where you apply it, but doesn't propagate.
If there is an end repeat barline and you add a start repeat barline to the next measure, this works and results in a an end/start repear barline in score and parts.
MuseScore 2.0.3, 2.1 3d0347f, Windows 7
Not in master, af9062701, though.
Fix version
3.1.0
Comments
wow, I can confirm those cases.
Also if I drop a End/Start Repeat Barline to a regular Barline or to an End Repeat Barline to a part, then the other parts and the main score only get a End Repeat Barline.
But interestingly no bug happens if I first apply a Start Repeat Barline to main score or a part, and then drop an End/Start Repeat Barline ontop of it in a main score or a part, then the mainscore and parts properly change...
I've made test .mscx and reference and started to make test case barline179366() which will "apply each type of barline [single, double, start, end, end-start] to each type of barline, either from main score or from parts" https://github.com/ericfont/MuseScore/commit/6221b9ac0a6bab0819c346df99…
This seems consistent, adding an end/repeat barline does seem to touch the barline at the start of the nex measure. And the start repeat barline is a Special case anyway, as it is the onle that applies to the start of a measure (only), all other apply to the end of the measure. I guess in that special casing for the start repeat the end/start repeat got omitted, as needs to apply to the end of the current and the start or the next measure?
My understanding is that these repeat barlines are not first class elements anyhow, that they get generated from the repeat property on the measures themselves. And it looks like maybe this property is what is not being linked correctly - perhaps because it's "link" attribute is set to false in property.cpp?
I think in this special case there are 2 properties to be used, repeat end on the measure before that end start repeat and repeat start to the measure after and it seems the latter is missing
Hmm, doesn't seem to be the case libmscore/undo.cpp, lines 3622-3634 look OK to me.
And the properties are set for progation, libmscore/property.cpp. lines 155 and 156 .
Maybe the problem is in libmscore/barline.cpp. lines 600-620 ?
I should unassign myself. I was comparing behavior with 3.0 but got sidetracked with a bunch of barline bugs in 3.0.
6e3c247 fixes this for master
@ericfontainejazz: your mtest don't seem to cover this case, does it?
@jojo, no I wasn't covering that case in the mtest. I intend to submit another mtest today for verifying behavior across parts & main score.
Came up again https://musescore.org/en/node/272163
no longer an issue in 3.0
Automatically closed -- issue fixed for 2 weeks with no activity.
Not even after re-introducing the end/start repeat barline in 3.1, see #283828: Add end-start repeat barline back to barlines- and repeats palettes
Right, to be clear: although the element is now back on the palette and can be added as a true barline type mid-measure, when used on a regular barlines, it continues to just set the repeat flags on the measures themselves. In other words, its effect should always be the same as adding the two barlines individually.