Page Settings - Redundant "undo" entry

Niels Erik Nielsen 2

• Aug 26, 2018 - 21:11

Type

Graphical (UI)

Frequency

Once

Severity

S4 - Minor

Reproducibility

Always

Status

closed

Regression

Workaround

Project

MuseScore

In the Page Settings dialoge an unnescessary undo entry is created if you press OK with no pending changes.

Clicking OK should check if any changes were made between clicking Apply (or opening the dialog box) and OK and if there were none simply close the window with no other background work, to include adding an undo entry.

Comments

neGjodsbol

• Oct 22, 2018 - 21:34

Severity		⇒
Status (old)	active	⇒	patch (code needs review)
Status	active	⇒

Links to:
https://github.com/musescore/MuseScore/pull/4019

Anatoly-os

• Oct 26, 2018 - 19:40

Severity		⇒
Status (old)	patch (code needs review)	⇒	active
Status		⇒	active

Still not fixed by https://github.com/musescore/MuseScore/pull/4055

neGjodsbol

• Oct 26, 2018 - 19:52

I am aware og this. Will try to come up with specific solution for this issue.

Anatoly-os

• Oct 26, 2018 - 20:39

Thank you.

neGjodsbol

• Oct 28, 2018 - 15:09

Severity		⇒
Status (old)	active	⇒	patch (code needs review)
Status	active	⇒	PR created

Links to
https://github.com/musescore/MuseScore/pull/4072

Git Message

• Mar 12, 2020 - 13:33

Severity		⇒
Status	PR created	⇒	fixed

Fixed in branch master, commit 001c34c1b0

Fix #275659: Redundant undo entries

Jojo-Schmitz

• Mar 12, 2020 - 13:45

Severity		⇒	S1 - Blocker
Reported version	2.1	⇒
Regression		⇒	No
Workaround		⇒	No
Fix version		⇒	3.5.0

dmitrio95

• Mar 12, 2020 - 13:56

Severity	S1 - Blocker	⇒	S4 - Minor
Frequency		⇒	Once
Reproducibility		⇒	Always

Well, that wasn't probably a blocker :) But, anyway, already fixed.

Jojo-Schmitz

• Mar 12, 2020 - 14:00

oops

System Message

• Mar 27, 2020 - 09:00

Status

fixed

⇒

closed

Automatically closed -- issue fixed for 2 weeks with no activity.

Fix version

3.5.0