Note input mode is incorrecrly switched for tabulatures and drumsets

• Sep 28, 2018 - 13:04
Reported version
3.0
Priority
P1 - High
Type
Functional
Frequency
Once
Severity
S3 - Major
Status
closed
Regression
No
Workaround
Yes
Project

Steps to reproduce:
1. Create a score with a treble clef and a tabulature/drumset staff.
2. Enter some input mode (for example, Real-time automatic), ensure it works for the treble clef (play something on virtual piano board or MIDI keyboard for Real-time mode).
3. Click on the tabulature/drumset staff.
4. Switch to the default (Step-time) input mode.
Expected results: input should switch to Step-time mode, Real-time mode is not working.
Actual results: the previous input mode (Real-time in this example) is still working.

Issue #276670: Crash on mouse press on tabulature in Repitch input mode might be also related to this so I suppose fixing this issue can potentially fix that one too.


Comments

Priority P2 - Medium P1 - High
Severity S4 - Minor S3 - Major

Running into this right now myself. Somehow it seems changes of input mode just don't register correctly while you are on a drum staff. Workaround I guess is to be on a standard staff when switching modes, but that's not acceptable. Working on this with some other rhythm mode fixes.

Status PR created fixed

Fixed in branch 3.x, commit 42085e18bc

_fix #276671: note input submode not switched for tab or drum staves

Resolves: https://musescore.org/en/node/276671

When switching note input modes (steptime, repitch, rhythm, etc),
the handlers for drum and tab staves was missing the code
to actually set the mode.
So the icon would show the change but no change was registered.
This made rhythm mode difficult to use for drum staves;
you needed to discover the problem and workaround.
Tablature doesn't actually implement all these modes,
but it is still important to set the mode correctly internally
so it reflects the icon correctly when switching staves.
Added the code to do this._

Fix version
3.5.0