signed vs. unsigned char returning in master

• Nov 30, 2018 - 21:13
Reported version
3.0
Priority
P1 - High
Type
Functional
Frequency
Once
Severity
S1 - Blocker
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project
MuseScore

https://launchpad.net/~mscore-ubuntu/+archive/ubuntu/mscore-nightly/+so…

Some architectures fail to build, e.g. https://launchpadlibrarian.net/399724960/buildlog_ubuntu-bionic-arm64.m… has:

In file included from /<>/musescore-snapshot-3.0~pre20181127+dfsg1/libmscore/note.h:26:0,
from /<>/musescore-snapshot-3.0~pre20181127+dfsg1/libmscore/durationtype.h:17,
from /<>/musescore-snapshot-3.0~pre20181127+dfsg1/libmscore/stafftype.h:19,
from /<>/musescore-snapshot-3.0~pre20181127+dfsg1/libmscore/xml.h:17,
from /<>/musescore-snapshot-3.0~pre20181127+dfsg1/midi/midifile.cpp:14:
/<>/musescore-snapshot-3.0~pre20181127+dfsg1/libmscore/tremolo.h:24:26: error: enumerator value -1 is outside the range of underlying type ‘char’
INVALID_TREMOLO = -1,
^

We fixed this in 2.x IIRC, mostly by specifying 'signed char' or 'unsigned char' explicitly as enum type. If you just use 'char' you can only use values 0‥127 portably (ASCII).

Comments