I believe it's usually on the right. Here are some other MuseScore dialogs where that's the case.
Is this one of those things where it's different on different operating systems? This shots all from Mac.
There is a QT feature that attempts to lay out button in standard order for the OS. That's not used on the Instruments Dialog, but is used quite widely in MuseScore dialogs.
I believe you are right, OK is generally on the left on Windows so all looks consistent and correct to me on my system, but if it works differently on macOS, that's fine as long as long as it's also correct and consistent, and right now it is apparently inconsistent. Whether they really should all be on the right or not I'll leave to a macOS expert to say.
Seems an easy change, instead of using two QPushButtons using one QDialogButtonBox with an OK and Cancel button, then let Qt deal with the defaults.
This is not the only dialog having this issue, e.g. Page settings, Insert measures
What I thought would be a five-minute fix for one dialog turns out to be far from it. Digging around more of the dialogs there's quite a mixture of styles used in MuseScore just now and not so much consistency. For Mac users, at any rate, the ordering of OK and Cancel is inconsistent across dialogs.
Here's an initial list - not doubt with some missing entries:
Need attention - will NOT adapt to different platforms and create inconsistency (at least) on Mac
Instrument [instrDialog.ui] manually laid out QPushButton (OK. Cancel) (hard left) - order will not adapt to different platform conventions. In addition manually laid out QPushButton (Load..., Save As) (hard right) - these buttons are made invisible in code. I'm not sure if there's a context in which they are made visible.
Page Settings [pagesettings.ui] manually laid out QPushButton (OK, Cancel, Apply, Apply to All Parts) - order will not adapt to different platform conventions.
Probably OK - will at least partly adapt to different platforms
Preferences [prefsdialog.ui] uses QDialogButtonBox (OK, Cancel, Apply) and manually laid out QPushButton (hard left)
Score properties [metaedit.ui] uses QDialogButtonBox (OK, Cancel) and manually laid out QPushButton (hard left)
Format|Style [editstyle.ui] uses QDialogButtonBox (OK, Cancel) and manually laid out QPushButton (show/hide list) (hard right) + the Apply to All Parts button added to the QDialogButtonBox in code.
All good - will adapt to different platforms
Parts [excerptsdialog.ui] uses only QDialogButtonBox(OK, Cancel)
Add Remove system breaks [breaksdialog.ui] uses only QDialogButtonBox(OK, Cancel)
Transpose [transposedialog.ui] uses only QDialogButtonBox(OK, Cancel)
Plugin Manager [pluginmanager.ui] uses only QDialogButtonBox(OK, Cancel)
Comments
OK is always on the left. What's the problem?
In reply to OK is always on the left… by mike320
I believe it's usually on the right. Here are some other MuseScore dialogs where that's the case.
Is this one of those things where it's different on different operating systems? This shots all from Mac.
There is a QT feature that attempts to lay out button in standard order for the OS. That's not used on the Instruments Dialog, but is used quite widely in MuseScore dialogs.
I believe you are right, OK is generally on the left on Windows so all looks consistent and correct to me on my system, but if it works differently on macOS, that's fine as long as long as it's also correct and consistent, and right now it is apparently inconsistent. Whether they really should all be on the right or not I'll leave to a macOS expert to say.
Seems an easy change, instead of using two
QPushButtons using oneQDialogButtonBoxwith an OK and Cancel button, then let Qt deal with the defaults.This is not the only dialog having this issue, e.g. Page settings, Insert measures
In reply to I believe it's usually on… by Startled Bee
There's some helpful QT article on this: https://doc.qt.io/archives/qq/qq19-buttons.html
What I thought would be a five-minute fix for one dialog turns out to be far from it. Digging around more of the dialogs there's quite a mixture of styles used in MuseScore just now and not so much consistency. For Mac users, at any rate, the ordering of OK and Cancel is inconsistent across dialogs.
Here's an initial list - not doubt with some missing entries:
Need attention - will NOT adapt to different platforms and create inconsistency (at least) on Mac
Probably OK - will at least partly adapt to different platforms
All good - will adapt to different platforms
See https://github.com/musescore/MuseScore/pull/5141
There are at least 2 more then need attention: insertmeasuresdialog.ui and measuresdialog.ui
For pagesetting.ui the "Apply to all parts" button may need to move depending on platform, to not be separated from the Apply button