Characters needing HTML escaping cannot be entered into chord symbols or RNA

• Oct 17, 2019 - 20:22
Reported version
3.2
Priority
P1 - High
Type
Functional
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project

1) empty score
2) enter chord symbol: C<D (that's an angle bracket, in case the site changes it)

Result the < turns into &lt;. A subsequent edit turns it back, then it disappears.

We aren't managing xmltext vs. plaintext correctly, easy fix.


Comments

Title Characters needing HTML espcaping cannot be entered into chord symbols or RNA Characters needing HTML escaping cannot be entered into chord symbols or RNA

Typo in thread title.

Status PR created fixed

Fixed in branch master, commit b7824c8f4b

_fix #295778: incorrect handling of HTML escapes in chord symbols

We pre-populate the text of a chord symbol when commencing edit,
and process the text again upon completion of the edit.
But sometimes we used xmltext and other times we use plaintext.
It needs to be plaintext always for the conversion to work right:
we need to use plainText() when calling setHarmony(),
and we need to call setPlainText() when setting the text from the harmonyName()._

Fix version
3.3.0