Hiding courtesy time signature only works for the first staff

• Jan 3, 2020 - 18:41
Reported version
S3 - Major

Issue 1: In the attached file, select the time signature in measure 4, staff 2, open the inspector and uncheck "show courtesy". Nothing happens.
Press Undo, select the time signature in staff 1, and uncheck "show courtesy". The courtesy time signature disappears, but,
Issue 2: select the time signature in staff 2 and open the inspector. "show courtesy" is still selected, even though the courtesy time signature is not being displayed.
These issues do not occur with a courtesy key signature.

Attachment Size
Courtesy Test.mscz 4.69 KB


Title Issues when hiding courtesy time signature Hiding courtesy time signature only works for the first staff

I wonder why when selecting a global key signature, every other key signature in other staves are highlighted (selected), but when selecting a global time signaure, only the clicked one is. Personally I think the behaviours should be unified, which can probably make fixing this particular problem easier.

I think maybe this stems from the days before local time signatures were a thing. Something about making sure clicking a signature then hitting Delete would do what you expect (delete it on all staves, not just one). Not that this really explains it, but it's somehow relevant.

It seems the problem was indeed in selecting a time signature. Unlike selecting a key signature, which selects key signatures on all staves, selecting a time signature selects only one element. I don't see any reason to unify the behavior for key and time signature, except when the time signature is local.

Status PR created fixed

Fixed in branch master, commit 37dfa26712

_fix #299246 and fix #284434

This commit solves 2 issues:

issue 299246 : Hiding courtesy time signature only works for the first staff
issue 284434 : "hide courtesy key signature" not working when hiding for only one staff of multiple-staff score from context menu

When selecting a time signature, it now shows the same behavior as selecting a key signature which solves
Key Signature had exactly the same problem as Show/Hid Courtesy Time Signature. This is solved
similar for both key and time signature.

Also, in propertymenu.cpp all static_cast() replaced by toXx(), according the coding rules._

Fix version