Initial position of Continuous View is misplaced a bit

• Dec 17, 2014 - 09:35
Type
Functional
Severity
3
Status
closed
Project
MuseScore

1. Switch to a continous view.
expected: screenshot2
actual: screenshot1
I think the staff has to be one pixel to the right and it will do.
Note: The problem doesn't occur if a staff has specified instrument's name.
Win7, abbf2c8

Attachment Size
s1.GIF 23.86 KB
s2.GIF 15.78 KB

Comments

• Dec 17, 2014 - 13:18
Title The initial position of a continous view is misplaced a bit ⇒ Initial position of Continuous View is misplaced a bit
Severity ⇒

Reply

• Dec 17, 2014 - 23:50

I looked at this and found while it's easy enough to change the initial position to not require the panel overlay, it will still shift and the panel will appear as soon as you begin entering notes. And given #32886: In Continuous View, the last visible measure is moved under the continuous panel, I'm not sure it even makes sense to try to avoid displaying the panel initially.

Anyhow, the fix is simple, but probably makes sense wait until if/when we do something about the other issue.

Reply

• Dec 19, 2014 - 05:46

Personally, my fix for this issue would be to simply change the zeros for 1s on lines 3730
and 3731 in ScoreView.cpp

It would become :
if (xo > 1)
xo = 1;

This would prevent the panel from showing up.

Reply

• Dec 20, 2014 - 04:07

I'll add it since I already have the branch going and want to see how they play together and if I can make it so note entry doesn't immediately cause the panel to appear.

Reply

• Dec 20, 2014 - 05:04
Severity ⇒
Status (old) active ⇒ patch (ready to commit)

Good call; that also fixes the problem where note entry immediately causes the panel to appear unnecessarily. This plus my change (which also improves things with respect to frames) help.

I ended up using an x offset of 10 rather than 1. I like the small visible margin to the left, to help make it more clear you are at the beginning of the score.

https://github.com/musescore/MuseScore/pull/1559

Reply

• Dec 21, 2014 - 12:43
Severity ⇒
Status (old) fixed ⇒ active

Issue still present.
Shouldn't it be
if (x >0)
x = 10.0;
instead
if (x > 10.0)
x = 10.0;
?
(unless I get coordinates wrong)

Reply

• Dec 21, 2014 - 16:15
Severity ⇒
Status (old) active ⇒ needs info

Issue is still present in what form? I don't see it. Please post sample score and/or steps.to reproduce.

Reply

• Dec 21, 2014 - 17:33
Severity ⇒
Status (old) needs info ⇒ fixed

That build is not recent enough. Apparently the Windows nightly server is having issues. But the issue really is fixed as far as I can tell in my tests.

Reply