[Feature Request] Include mixer changes in undo history
Reported version
3.x-dev
Type
Functional
Severity
S5 - Suggestion
Status
active
Regression
No
Workaround
No
Project
1] Open Musescore 2.0 Beta and edit some instruments and notation
2] Open Mixer
4] Adjust the Volume of an instrument
5] Press Crt+Z (undo command)
Expected Result:
The adjustment will be undone.
Actual Result:
It only undoes changes in the score itself, not the mixer.
---------------------------------------------------
I found this issue while I was messing around with Musescore 2.0 Beta 2 mixer. Is there another way to fix it?
Comments
The "undo" command is really meant for changes to the score itself, not to the synthesizer state. Not that it couldn't some day be extended to cover that too. But it would be kind of unusual. That's kind of the equivalent of undoing a change of zoom settings.
Btw, the "Assigned" field is meant for listing who will fix a bug. So unless you're volunteering, I've unassigned you, and set back to "bug report", even though it's kind of more of a feature request.
Thank you for correcting the settings.
Because there was no way to pinpoint the desired sound adjustment of an instrument, I initially thought that Musescore would allow me to undo that change and set it back to exactly the right adjustment level, but that did not happen so I thought that it was a bug and reported.
However, as you have said, this was not an intended feature, so I guess the problem is solved then! Although, I think I should make a new post requesting a feature related to this.
See https://github.com/musescore/MuseScore/pull/1668
Synthesizer settings are global and not undoable. Mixer settings belong to a score and should be undoable. Its a limitation of the current MuseScore implementation. The settings are not undoable and worse, they do not set the dirty flag of a score.
OK, so true undo is *possible* since mixer settings are indeed attached to the score, but postponed since these changes are not set up to be undoable.
But as for the "reset" button - I assume there is no reason we can't have that? To me that's more useful than undo for the mixer anyhow. I updated my PR as you suggested. I was kind of surprised the capability of setting and restoring defaults didn't seem to exist, thanks for pointing out it was there all along but maybe not in the best place.
If we want to enhance the playback functionality of MuseScore in the future something called "mixer automation" comes into play. Mixer values may change over time. This means that the static values should be replaced by value lists, implementing a gui manipulating this lists etc. This is much different than the current implementation.
Fixed in a115337608
It's not undo, as discussed, but "reset". Either double click or press backspace/delete (if keboard focus is on the button).
Some day, a true undo may be implemented, but I'm assuming not for 2.0, so I'm changing the status of this to "postponed".
Mixer automation - that would be very cool too!
as 2.0 is released...
Unless I misunderstand this issue, it seems to have been fixed.
Yes, I misunderstood it.
OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.0.1.5053, revision: 56c6d86
+1.
@geetar - After reading through this issue and its description, everything here really talks about being able to undo mixer changes. As Marc has correctly pointed out, resetting the mixer is as simple as double-clicking the control - so it's pointless to request a feature that already exists. Both him and werner also point out that undoing mixer changes could be a valid feature at some point in the future.
Thus correcting issue description in the spirit of the original report and adding to #303762: [EPIC] Collection of Undo issues