There is no need for return key to apply the filter as the filter applies every time the text changes.
Also the behavior of return key is same everywhere in musescore, it closes the opened dialog.
If you're aware that the "assigned" field is to indicate that someone has volunteered to investigate the issue and submit a patch to the MuseScore code, and you're willing to do that, then I apologize in advance and you can reassign yourself.
Unexpected behaviour on pressing RETURN key while the cursor is in the filter box of Shortcuts tab.
⇒
filter textbox not cleared on reopening the Shortcuts dialog
Severity
⇒
Status (old)
active
⇒
patch (code needs review)
The actual issue is that the filter text-box is not being cleared again when the Preferences dialog is opened after closing again.
I have created a patch that allows doing so.
I'm not really sure that it's not the expected behavior. The filter in the instrument dialog works the same. If we change the behavior in the preferences dialog we should also change it in instruments for consistency.
Although , the results in the list are consistent with what is present in the filterbox of the instruments dialogue , but it is no harm clearing it for consistency .
Should I do so ?
I think I like it that the filter is kept in instrument dialog. Maybe we should make the shortcut dialog work the same and the shortcut should be filtered. Any other feedback?
Neutral. Either change would be preferable to the current behavior. However, the Symbols palette as well as the Instruments dialog currently keeps the filter.
I'm fine with either choice. I'm guessing it's more likely the user would want to enter a new filter next time they open either dialog, so clearing it would save the user a click in those cases, but re-entering the filter in the cases where you *do* want it takes several clicks, so it's probably a wash overall.
Comments
There is no need for return key to apply the filter as the filter applies every time the text changes.
Also the behavior of return key is same everywhere in musescore, it closes the opened dialog.
@kushagrasurana, actually, in some places the behavior is different: #63681: Hitting Enter in Instruments dialog repeats "Add" or "Delete" instead of applying "OK"
If you're aware that the "assigned" field is to indicate that someone has volunteered to investigate the issue and submit a patch to the MuseScore code, and you're willing to do that, then I apologize in advance and you can reassign yourself.
That's what abhinav_ expressed on IRC...
The actual issue is that the filter text-box is not being cleared again when the Preferences dialog is opened after closing again.
I have created a patch that allows doing so.
see https://github.com/musescore/MuseScore/pull/2430
I'm not really sure that it's not the expected behavior. The filter in the instrument dialog works the same. If we change the behavior in the preferences dialog we should also change it in instruments for consistency.
Jojo, Zack, any opinion?
I think we should clear both.
Although , the results in the list are consistent with what is present in the filterbox of the instruments dialogue , but it is no harm clearing it for consistency .
Should I do so ?
I think I like it that the filter is kept in instrument dialog. Maybe we should make the shortcut dialog work the same and the shortcut should be filtered. Any other feedback?
Neutral. Either change would be preferable to the current behavior. However, the Symbols palette as well as the Instruments dialog currently keeps the filter.
I also vote for this. Keeping the filter text saved , but displaying the shortcut list filtered.
I'm fine with either choice. I'm guessing it's more likely the user would want to enter a new filter next time they open either dialog, so clearing it would save the user a click in those cases, but re-entering the filter in the cases where you *do* want it takes several clicks, so it's probably a wash overall.
@abhinav_ would you modify your code to fix the preference dialog so it works the same than the instrument dialog?
Updated the PR. Please review.
Fixed in branch master, commit 1d9a81ca01
fix #100406
Fixed in branch master, commit d9b8a1e319
Merge pull request #2430 from abhinavaggarwal/fix_100406
fix #100406
Fixed in branch 2.0.3, commit 647d5d5e51
fix #100406
Automatically closed -- issue fixed for 2 weeks with no activity.