Just something I find that I always end up needing to do, so I'd like to add an option to do it automatically. Should the option be in preferences or in the AlbumManager ui?
Thanks Jojo. I see you had already raised the request: "and maybe a page break optionally" there
.
I'm wondering if in addition to adding option for PageBreak which would be OFF by default, to also add an option for SectionBreak which would be ON by default (to be consistent with current behavior).
Sound good to me. Not sure how to deal with cases where a section or page break already exists at the end of the score to join, something to check out.
Note those checkmarks are at the their default position. I chose to use a QGroupBox in order to keep the options for saving a joined score to be isolated from the "Print Album" button, so that it is clear that those options only affect the "Join Scores" button. Hypothetically, could add a seperate set of options for "Print Album".
Not sure how to deal with cases where a section or page break already exists at the end of the score to join, something to check out.
I would say that those checkmark options I have are only adding breaks - i.e. they will not remove breaks. So if none of them are selected, then if there is already a break at end of score to join, then whatever break was already at the end of that score will persist. I think this would be self-evident if use the wording "add".
yes, I guess that's true. The button texts probably need to get changed slightly, to match the proper casing style, "Add section break" and "Add page break", I think.
Notice I'm using full phrase "Add [section/page] break between scores". That might be a little more wordy than "Add section break", but I was wasting time debating with myself whether "break" should be singular or plural, so I just wrote out the full phrase.
what I mean is I'm not try to test is there is already a line break and then remove the line break...I'm just adding a page break. I don't know if that code should be smart by removing the line break if an line break exists, when adding a page break.
Comments
Album Manager, definitely.
See also the discussion in #20783: Joining scores via the album feature should separate the scores by a line- and a section break.
Thanks Jojo. I see you had already raised the request: "and maybe a page break optionally" there .
I'm wondering if in addition to adding option for PageBreak which would be OFF by default, to also add an option for SectionBreak which would be ON by default (to be consistent with current behavior).
Sound good to me. Not sure how to deal with cases where a section or page break already exists at the end of the score to join, something to check out.
I've modified the AlbumManager ui as follows:
Note those checkmarks are at the their default position. I chose to use a QGroupBox in order to keep the options for saving a joined score to be isolated from the "Print Album" button, so that it is clear that those options only affect the "Join Scores" button. Hypothetically, could add a seperate set of options for "Print Album".
I would say that those checkmark options I have are only adding breaks - i.e. they will not remove breaks. So if none of them are selected, then if there is already a break at end of score to join, then whatever break was already at the end of that score will persist. I think this would be self-evident if use the wording "add".
yes, I guess that's true. The button texts probably need to get changed slightly, to match the proper casing style, "Add section break" and "Add page break", I think.
I submitted a PR for review: https://github.com/musescore/MuseScore/pull/2536
This is what my AlbumManager ui looks like now:
Notice I'm using full phrase "Add [section/page] break between scores". That might be a little more wordy than "Add section break", but I was wasting time debating with myself whether "break" should be singular or plural, so I just wrote out the full phrase.
One thing to note, I'm not trying to be smart when I add page break: https://github.com/musescore/MuseScore/pull/2536/files#diff-da9ebe454ea…
what I mean is I'm not try to test is there is already a line break and then remove the line break...I'm just adding a page break. I don't know if that code should be smart by removing the line break if an line break exists, when adding a page break.
Fixed in branch master, commit c1c75fe5e5
fix #105716 Album option Page/Section Break
Fixed in branch master, commit 1cf5caf7a3
Merge pull request #2536 from ericfont/105716-AlbumManager-PageBreak
fix #105716 Album option Page/Section Break
I believe it won't harm to have this in 2.0.4 too
Fixed in branch 2.0.4, commit 6b98a9e2fc
fix #105716 Album option Page/Section Break
Automatically closed -- issue fixed for 2 weeks with no activity.