Master palette items are not translated

• Oct 25, 2016 - 08:20
Reported version
3.0
Type
Wording/Translation
Severity
S4 - Minor
Status
closed
Project
MuseScore

See https://musescore.org/en/node/138711

Master palette items are not translated, some show a double ampersand, &&, while their counterparts in the (advanced) workspace show only a single ampersand & and are getting translated (most of them, not Articulations, Ornaments, which recently got split into separate palettes, and Noteheads).
The code has the double && and it seems needed as some kind of escape character (see also https://musescore.org/en/node/138551)

fe1f451

Comments

• Oct 25, 2016 - 10:40

In 2.0 we used to have 2 strings for each Palette, one with context "Palette" (except "Symbols, with context Ms::MuseScore from musescore.cpp), from menus.cpp (and those with &&) and another with context "MasterPalette", from masterpalette.ui (those with just a single &).
And even a 3rd string for "Key Signatures" and "Time Signatures", with context "Ms::MuseScore" from musescore.cpp). Context "MasterPalette" is gone with e6997f3, where masterpalete.ui. got reduced and masterpalette.cpp got reorganized, that probably is where/when the translation of the master palette broke.

My PR tries to reduce to just one string for each palette.

Reply

• Nov 15, 2016 - 20:10
Status (old) patch (code needs review) ⇒ fixed

Fixed in branch master, commit ec784b9e54

fix #138721: translate master palette items

and reuse existing translations for "Key Signatures", "Time Signatures"
and "Symbols", not just to reuse but also to make sure they when used as
an (optional) argument to MasterPalette::showMasterPalette() and work
properly when invoked via a shortcut.
In master palette get rid of double ampersands in palette names.

Reply