MuseScore 2.1 fails to build with BUILD_LAME=FALSE

• May 16, 2017 - 01:03
Reported version
2.1
Type
Functional
Severity
S4 - Minor
Status
closed
Project
MuseScore

If BUILD_LAME is set to FALSE in the Makefile, MuseScore fails to build. This is because canSaveMp3 and saveMp3 are defined in mscore/exportmp3.cpp, which is not included. This did not occur with MuseScore 2.0.3.

CMakeFiles/mscore.dir/loginmanager.cpp.o: In function `Ms::LoginManager::onGetMediaUrlRequestReady(QByteArray)':
/home/abuild/rpmbuild/BUILD/MuseScore-2.1.0/mscore/loginmanager.cpp:406: undefined reference to `Ms::MuseScore::saveMp3(Ms::Score*, QString const&)'
CMakeFiles/mscore.dir/uploadscoredialog.cpp.o: In function `Ms::UploadScoreDialog::showOrHideUploadAudio()':
/home/abuild/rpmbuild/BUILD/MuseScore-2.1.0/mscore/uploadscoredialog.cpp:196: undefined reference to `Ms::MuseScore::canSaveMp3()'
collect2: error: ld returned 1 exit status

Comments

• May 16, 2017 - 03:38

or maybe I'll move the definitions for canSaveMp3 and saveMp3 from exportmp3.cpp into something that is always available, like mscore.cpp, and then if the flag is false, then have those functions return error code.

Reply