Double clicking on a pallet item should not add two identical elements

• Dec 4, 2020 - 11:02
Reported version
3.5
Priority
P1 - High
Type
Ergonomical (UX)
Frequency
Many
Severity
S5 - Suggestion
Reproducibility
Always
Status
active
Regression
No
Workaround
No
Project

Since single clicking to add a pallet item was implemented there has been a steady stream of users reporting various problems caused by multiple identical overlapping and hence un-seeable items (notably voltas) being found in their scores to their surprise ("I didn't add them!"). It seems fairly certain that this is a result of the user using the old double click method to add an item.

My suggestion is that when adding pallet items, both single and double click should be interpreted as single click.

Alternatively, a check for the presence in the score pre-existing identical (i.e. identical type, and location) element should be made on any click and if such an element is found, the user should be warned that they are about to duplicate it. However, this is probably a less helpful and more difficult to implement option.


Comments

+1

In windows it is common to need to double click on items rather than single click like on a Mac. Windows users are used to this so the option to double for windows users should remain.

"Steady stream" would suggest a higher frequency than "few"?

At any rate, this seems like an important thing to change.

Frequency Few Many

We seem to have reached the 5=many threshold in this thread.

The "steady stream of users" probably haven't complained about the "double click problem" as they are unaware that their problems arise from double clicking. The results are not apparent visually unless they try to drag the doubly entered item. Their posts arise mainly from the effects of the doubly entered voltas on playback.

FWIW, this seems to only happen for lines as far as I can tell, Suggesting that at some level, we are already handling this correctly, but the line handling is missing whatever is going on for the other elements. Unfortunately I don't understand enough QML to be able to deal with this.

Included in lines are voltas. jeetee is fixing the problem this issue has caused with them because they are not as obvious as some other items that get double added.

Unfortunately I don't understand enough QML to be able to deal with this.
Me neither. To me this is the biggest and most important disadvantage of QML code inside MuseScore

Agreed. I realized a couple of weeks ago this is the root cause of the volta problem but I was trying to figure out how best to discuss it. This issue gave me the opportunity. The bugs jeetee is fixing are real so I don't have any guilt for not mentioning it previously.

Indeed, it's absolutely worth fixing the crashes that occur if double voltas are added, since no doubt double-clicking isn't the only way to create that issue. Consider also, for example, adding a volta to the top staff, then attempting to add voltas to each subsequent staff. They are system elements so they actually keep stacking on top.

As for QML, I can only hope that the "powers that be" are correct in their faith that while the various code structure changes being implemented may make things harder for us old-timers, they may somehow improve the situation for newcomers. It's a reasonable goal, even if it doesn't benefit me as personally as a developer.