Start repeat bar appears at end of system in My First Score, scores created with Beta

Duplicate of #18510: incorrect barlines with start repeat at beginning of system? If so, it is fixed in the nightly builds

It is indeed a duplicate. I'm not 100% convinced there will never be any cases where this happens any more, though, so if the OP has test case where it happens even in the latest nightly build, please post it. Although if the score was created using a build from more than a week ago (eg, the Beta 1), you might still see the open repeat at the end of the line until you remove the line break or start repeat and re-add it.

Was this score created in the latest nightly, or in an older build? As I said, you might have to delete previously-existing barlines and/or line breaks in order to see the fix. If I try to create a score like yours from scratch, it loads just fine. It also works fine if I delete the repeats from your score and add them back.

If this was created in the latest build, please describe step by step how you created it.

And I don't understand what you mean about parts. The loaded file doesn't contain parts. If I generate one, the start repeat is not at the beginning of a line. And if I add a line break, it works correctl

I can't reproduce with your steps
Using bdbaf5a (one commit newer than yours) on Windows 7 Enterprise, 64bit

I can't either, but the steps don't really make sense. Nowhere in the steps does it say to add a line break in the first place, so at step 3, there is no line break to delete. So I tried the following instead:

1) new score 32 measures
2) add line break after measure 4
3) add start repeat to measure 5
4) delete line break at end of measure 4
5) click start repeat, hit Enter to add a new line break

This all works fine.

However, it instead of actually creating a new score from scratch, I use the "My First Score" - which *does* already have a line break after four measures - then I see the problem. I'm guess this just means "My First Score" needs to be updated, Perhaps the same for the templates, although when I just tried it using Jazz Lead Sheet, it worked fine.

Also do be sure you really are using the nightly and not the beta, which would indeed still have the bug. Go to Help / About to be sure.

Please verify if you really are creating a new score from scratch and not simply using "My First Score", and if so, that you really are running the nightly (by reporting what Help / About says).

Marking as active because at the very least, we need to update My First Score.

I can't from scratch either, but I can using "My first score".

Question: why is "My first score" a single-staff piano? If we're presenting people with a scratch score to start them off, why not one that matches what a piano score normally would be?

guess scheper's change was an accident

You mean the change from "active" to "needs info"? I didn't knowingly do it. I was replying to your comment, which was already set to the "needs info" state, so I think mine simply inherited that state.

that's what I meant, your post and Marc's crossed

OK, good, then this much at least is an easy fix!

Regarding why My First Score is single staff - might as well ask, why piano? I guess there needs to be some number of staves, and some sound. But I don't think it is assumed people really do want to write for piano necessarily.

Wouldn't we need a fix that catches all scores created between Beta 1 and the nightly that fixed the issue (3338af928)?

If possible, that would indeed be good. Miwarre is the one who implemented all the changes involving how barlines get represented. From what I understand of it, barlines are no longer written to files at all unless they are "special" in some way. My First Score, and other beta-era scores, have all or most of their barlines marked "special" (non-generated) and thus are written to the files. And it's the fact that ordinary barlines are marked non-generated that was the nuderlying cause of the bug, I think. I'm not sure if it's possible to differentiate these non-generated barlines from the ones that really are "special" in some way. Except that of course, double bars are marked explicitly as such, so are the other things that I know of that might mark a barline non-generated. What I don't know is if there are other cases I am not aware of where a barline gets written to the file because it is non-generated and needs to remain non-generated for some reason. But hopefully, we can just ignore barlines written to files thaqt are not obviously special and hence didn't need to have been written to the file.

Not sure what I wrote makes sense, but hopefully it will to Miwarre, or at least, he'll know what does.

Title changed to reflect current status. Fixing My First Score is a no-brainer. Whether it's possible to fix scores created with earlier builds I'll leave to Miwarre to figure out.

Miwarre's recent fix means we shouldn't see the problem any more in My First Score or other Beta-era scores - they are fixed automatically on read. Leaving the issue open to remind us we should still update My First Score and the templates.

The fix posted on github has been merged.

Please check that the issue is indeed fixed.

Fixing My First Score and templates is probably useful for consistency but it should not be any longer absolutely necessary: the code now fixes the uselessly 'special' bar lines on reading.

M.

Fixed in 386775a, PR #1361 , however the templates and sample score(s) should get fixed too, even if not strictly necessary

Templates were presumably fixed with the updates for Beta 2? The jazz ones appeared to be, anyhow - no more barline tags aside from the final. Anyone know differently, or can I close this?

Bugs me to still see this not closed :-). If someone discovers a problem, we can reopen, or maybe better, file a new issue to discuss whatever specific is wrong, since the general cases discussed here were fixed long ago.

Automatically closed -- issue fixed for 2 weeks with no activity.