Noteheads in drum palette reflecting voice colour

• Dec 22, 2014 - 16:45
Type
Functional
Severity
3
Status
closed
Project

In the drum palette, all noteheads are now black, instead of the former multi-colour (reflecting the voice of the drum).

The latter is useful in being able to determine how drums are input.


Comments

I don't think colored noteheads ever had been in the drums palette for any 1.x release or 2.0 beta or nightly, if it was, it got to be something you put in there somehow?

They are black for me in 1.3 as well. Plus, the norm is for stems up voice one, sterms down voice 2. Wouldn't normally be a reason to mess with that, so it should be obvious enough. Still, seems a harmless enough suggestion.

Confirmed, colors were present in Beta 1 for me as well. Seems likely it is something I inadvertently broke with one of my fixes for drum entry, perhaps even with the implementation of slash notation. But none of the commits in the relevant files seem like they have caused this.

OK, I think I figured it out. Seems to be an unintended side effect of this:

https://github.com/musescore/MuseScore/commit/cf92afb3a13c0f1a3b49573a1…

The coloring of the drum palette was achieved by forcing each palette entry - a "Chord" object - to be selected before drawing it, and selecting something normally has the effect of making it show in the appropriate color for the voice. However, selecting a Chord object used to automatically select all Note objects within it, and now it doesn't any more, so the notes are no longer colored.

I don't totally understand the reasons why selecting a chord should not select the notes, and I wonder if the fact that the code was left in place but commented out means this it was going to be revisited later. But in case, we should be able to restore the color by selecting the notes rather than the chord when drawing the palette (or something like that).