Update rest icon to show other durations than quarter rest
It's been mentioned a couple of times that MuseScore's UI for rest entry is somewhat non-intuitive—in particular, the fact that there is a toolbar icon showing a quarter rest, which leads people to wonder where they can get an eighth rest from.
At https://musescore.org/en/node/22211, I initially proposed changing that image to show different durations. Now, I want to return to the issue.
The current rest input icon that needs replacing is at https://github.com/musescore/MuseScore/blob/master/mscore/data/icons/re…. My preliminary effort is attached to this post.
However, it's not formatted to match the rest of the icon set. I know nothing about working with SVG code. I can't do this alone. Can anybody turn the attached file into a workable version?
Attachment | Size |
---|---|
Rest_0.svg | 2.96 KB |
Comments
I'm not particularly good with this either, but thought I'd mention some other ideas I can recall being mentioned (or maybe I made some of them up):
1) have the rest toggle icon change appearance according to the selected duration (as mentioned above)
2) have the note duration icons change to display images of the corresponding rests if the rest toggle icon is selected (but would it be weird to have a row of rest durations icons plus a rest toggle icon?)
3) do away with the rest toggle icon and just have 10 more duration icons for the rests (this can also save a click when changing between note and rest and changing duration at the same time)
4) allow rests to be entered without needing to pre-selecting any sort of rest mode, by some special click operation - eg, Alt+click, or maybe double-click (this wouldn't be easily discoverable, but would probably the single most *efficient* way of doing mouse entry)
If the focus is on making rest input more intuitive, 1) and 4) don't seem to pass the test. 3) would, but at the expense of significant screen real estate, and I still hold to the premise that a rest is only a type of note with a pitch of 0. (Basically, if we don't have separate icons for every different pitch each duration can have, why should we for the specific class of rests?)
2) seems like the most likely of those four. [EDIT: especially if used in tandem with my suggested change to the rest icon!] But I assume it would be complex to implement (after all, even the Play icon doesn't turn into a Pause icon in any context), and given the choice, I'd rather stay closer to the current, simple system.
I would actually like the see rest input be both more intuitive *and* more efficient. Well, it's already optimally efficient when using the keyboard, and can be made so when using MIDI, but there is still one extra click to deal with when using the mouse - and no obvious way to enter rests at all from the Piano Keyboard (except of course to switch to another method).
So for me, #4 helps the efficiency and could be considered *in addition* to a method that helps with intuitiveness but doesn't address efficiency. #3 is the only one on the list that does both at once, but even so, #4 would save a click there too. I agree that one should be able to think of entering a rest as just like entering a note except with a "special" pitch, but nothing about mouse entry currently supports that line of thinking. You have to use this whole different method where you enable "rest mode" as a submode of "note input mode". #4 is the only suggestion above that actually makes rest entry more like note entry, but of course it is no more discoverable than any other method.
#1 and #2 help with discoverability, but indeed, #2 more so than #1 *if* we adopt your icon or one like it. But even for #1, I think that seeing the rest toggle icon change appearance as you change note durations would help discoverability. I'm doubt it's particular hard to change icons on the fly, and maybe we *should* change from play to pause during playback.
It is of course worth looking at how other programs do this.
I immediately thought of #2 & #3 when I read the title. I don't like #1 alone.
Let me also suggest an idea #5 for mouse input:
Currently mscore only allows user to input a note/rest at a currently-existing segment. This works great for keyboard, but when using a mouse, I would like to be able to position my cursor at any division of the measure (based on the selected duration) and plop an note, without inputting resets prior (mscore will input those for me). The blue "shadow note" will appear where these divisions of the measure are, to let user know. This would speed up the common case of non-synocpated music (but if I wanted to insert say a quarter note on an offbeat, would still have to input an 8th rest first).
EDIT: let me call (#5a) mean the above where permitted divisions of measure are deteremined by selected duration. Let me call (#5b) mean permitted divisions of measure be determined by a grid setting (either selected via preferences, or maybe a pulldown menu on toolbar).
You can find the rests SVG at https://github.com/musescore/MuseScore_design/tree/master/icons/24/acti…
It should be doable to make a icon with multiple rests on it.
Switching the icons should be easy to do in MuseScore::updateInputState().
The quarter rest icon confused somebody else: https://musescore.org/en/node/112311
Again! https://musescore.org/en/node/113986 Can anybody who understands SVGs please help with Rest_0.svg ?
Although my personal preference would be option 2 and have the current rest-icon become a rest/note toggle icon(?) perhaps this svg helps out shortterm?
It uses the real svg-data from the quarter and eight rests, the half rest has been reworked to be less wide for a better fit.
I've got nothing against option 2, but that may be a hassle to implement, and anyway this would still help people figure that out, too.
Thank you so much for helping out with this. I'm not sure if it may be an optical illusion, but is the image not quite centered? It looks like this:
(Still incalculably better than my effort.)
I think this is a great idea! "Currently mscore only allows user to input a note/rest at a currently-existing segment. This works great for keyboard, but when using a mouse, I would like to be able to position my cursor at any division of the measure (based on the selected duration) and plop an note, without inputting resets prior (mscore will input those for me). The blue "shadow note" will appear where these divisions of the measure are, to let user know."
Well, that's something entirely different from the icon set.
Thank you so much for helping out with this. I'm not sure if it may be an optical illusion, but is the image not quite centered?
Oh yes, I just quickly threw something together then. rest.svg is now aligned as follows:
I've also made a vertical swap of the half and eight rest in an attempt to lessen the visual emptyness between the quarter and the eight rest in the above sample. Don't know which one is turning out better though (see rest-swapped.svg)
I'd drop the line under the half rest, so it is valid for half and whole rest ;-)
Adjusted as per IRC with Jojo. svg-with-alignmentgrid added for reference and possible future improvements.
New icon within the guides:
I have a preference for the half/whole rest above the eighth—to me the quarter and eighth seem to fit with each other better that way, like South America and Africa across the Atlantic.
There you go, the eight rest wasn't just swapped but also slightly moved down- and inwards to better fill the area visually imo:
And just for the fun of it:
"Let the alignment preference wars begin!"
I vote for #16 :-)
However, I also liked #12 with the half rest (to me it looks nicer, because there is actually no rest symbol without the line in real life), that takes into account that you cannot create a full measure rest (also displayed by a full rest) using this button. But that's probably not so important.
You can create a whole rest though
Hmm... maybe it is better with the rectangle below the eighth rest, because now it strikes me like a tenuto on the rest. Whatever; I retract my expressed preference from comment #15—it's good either way.
It doesn't seem to work right as an actual icon, though, now—too small, and the half/whole rest isn't responding to the color correctly:
Darn.. forgot to remove the 5px padding I had included during testing. Also made the way the color is set to the block rest conform with the others.
If that doesn't fix the size, then I can also upscale this one to not have internal padding (the green border of alignment). Currently this is the same as with the original rest.svg icon though.
Do you want me to make one with the half rest on top instead of the block? After all, we're not showing 16th rests on there either… so who cares about a whole rest (sorry Jojo :) )
I sortof liked the half rest...it made the eighth rest look like a person wearing a hat. :)
More useful criticism: the half rest is more recognizable than the simple dash. I agree with #16 that the dash just looks like a tenuto marking. Anyway, we are not trying to include every type of rest in the icon, since we are not including 16th, 32nd, 64th rests, so no need to try to have a dual half/whole rest which ends up looking like neither (without the context of a staff line).
Anyway, when a whole rest is in voice 1 without any staff line for reference, it still doesn't look like a dash:
So I vote for a hat.
Maybe go back to putting the block below the eighth? That was a good idea, and I regret discouraging it.
The block below the 1/8 is most satisfying to me.
OK. lets call these the final contestants unless some major improvement can be made:
@Isaac: did you have a chance to test whether the alignment within MuseScore is now better?
The hat is cool. I say go with it. It looks like this:
I've got a branch ready to go, but I feel like you should be the one to make the pull request.
Here's my branch: https://github.com/IsaacWeiss/MuseScore/tree/99476-rest-icon
@Isaac, go ahead and PR, you're all set anyway.
https://github.com/musescore/MuseScore/pull/2674/
Thanks again for the help.
Now, maybe another feature request for Marc's (2), with the note icons changing to rests...
or rather the rest icon change to the selected duration
That would be 1), not 2).
Fixed in branch master, commit 6867b0e1b7
Fix #99476: Update rest icon to show other durations than quarter rest
Fixed in branch master, commit 9c653209ab
Merge pull request #2674 from IsaacWeiss/99476-rest-icon
Fix #99476: Update rest icon to show other durations than quarter rest
Fixed in branch 2.0.4, commit f1f49fc65b
Fix #99476: Update rest icon to show other durations than quarter rest
Automatically closed -- issue fixed for 2 weeks with no activity.
@Jeetee, one further thought on this: it might be an improvement to move it a tiny bit to the right, completely discounting the "hat-brim" for the centering of the button. Currently it's half-in and half-out, but it does make it look like the icon is shifted slightly to the left.
Hat guy now leans on the edge, as the lazy resting rest he is ;)
Thank you! https://github.com/musescore/MuseScore/pull/2718