"Would you like to try our improved style?" window opens with the last tab.

• Jan 6, 2021 - 22:36
Reported version
3.6
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project

Using latest nightly OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.6.0.465183078, revision: 905e64b

I previously closed the program with a couple of 3.5.x scores after not accepting the "improved style." When I opened 3.6 the "...improved style" dialog box opened with the final tab for each 3.5.x score that opened with it. What has happened in the past is that this window opened when you switched to the score's tab so you would know which score the dialog was asking about.

To be clear. I had two 3.5.2 scores opened in the last session and two 3.6 score. I closed and reopened the program and the "...improved style" dialog opened twice with the last score that opened, which happened to be a 3.6 score. Since this is an update to the RC I would consider it a blocker since the final 3.6 version cannot be released with this bug.


Comments

Severity S1 - Blocker S3 - Major
Priority P0 - Critical

It may be a release blocker (I'll let others judge), but let's not change the meaning of the severity field. Instead I've set a high priority for it to be looked at.

I take it you are referring to starting with the "last session" option? Because normally, no dialog at all appears on startup.

On Mac, when I select multiple files and press Cmd+O to open them all, I can also reproduce this:
- the first tab (with the first score) becomes the active tab;
- for each score, the migration dialog is shown;
- as a result, the dialog for the last score is on top, and thus affects not the visible score.

But when I drag multiple files onto MuseScore's window, it happens as I would expect:
- all files are opened;
- the last score becomes the active score;
- a dialog is shown only for the last score and thus affects the visible score;
- as soon as you switch to another tab, a dialog for that tab is shown.

Status PR created fixed

Fixed in branch 3.x, commit cf06baaea8

_Fix #315237: Don't switch tab when opening a score when a modal is open

  • Don't switch tab when opening a score when a modal is open
  • Make ScoreMigrationDialog QQuickWidget, so that it gets recognized by QApplication::activeModalWidget()
  • (This caused an issue that the QML content wasn't focussed when the dialog was opened, which I fixed too.)

Result:
- When you open one score, it is appended to the tab bar, and its tab is activated
- The ScoreMigrationDialog for that score is shown
- When you open a second score, it is appended to the tab bar, but its tab is not activated, because a modal dialog is open (namely the ScoreMigrationDialog for score 1)
- When you close the dialog for score 1 and then switch to score 2 's tab, the ScoreMigrationDialog is shown for score 2._

Fixed in branch 3.6.1, commit afd77dfaa7

_Fix #315237: Don't switch tab when opening a score when a modal is open

  • Don't switch tab when opening a score when a modal is open
  • Make ScoreMigrationDialog QQuickWidget, so that it gets recognized by QApplication::activeModalWidget()
  • (This caused an issue that the QML content wasn't focussed when the dialog was opened, which I fixed too.)

Result:
- When you open one score, it is appended to the tab bar, and its tab is activated
- The ScoreMigrationDialog for that score is shown
- When you open a second score, it is appended to the tab bar, but its tab is not activated, because a modal dialog is open (namely the ScoreMigrationDialog for score 1)
- When you close the dialog for score 1 and then switch to score 2 's tab, the ScoreMigrationDialog is shown for score 2._

Fix version
3.6.1