Change of slur direction does not take effect until the next relayout

• Oct 27, 2019 - 19:01
Reported version
3.x-dev
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project
MuseScore

MS 3.3 RC3.

Open the attached file. Try to change the direction of the slur through the Inspector or by keyboard shortcut ("X"). Nothing happens.

Attachment Size
slurs_issue.mscz 6.92 KB

Comments

• Oct 27, 2019 - 19:25
Severity S2 - Critical ⇒ S3 - Major
Priority ⇒ P0 - Critical

Confirmed, applies to all slurs - flipping does not take effect until next layout. It's not critical severity by our official definition, but definitely very serious, and critical in priority.

Reply

• Oct 28, 2019 - 08:37
Status PR created ⇒ fixed

Fixed in branch master, commit 83fe78e58a

_fix #296171: fix triggerLayoutAll() for spanners

Fixup for 99c7b0d74675df6880af6647b027ac34e53b8569
triggerLayout() and triggerLayoutAll() implementations in Element
have an optimization that allows to avoid triggering layout for
elements not yet added to a score by checking the element's parent.
This optimization is not suitable for spanners since they don't have
a parent even when added to a score. This commit adds a missing
implementation of Spanner::triggerLayoutAll() that takes this into
account._

Reply

Fix version
3.3.0