Reading 2.x score ignores all text style offsets

• Nov 13, 2019 - 00:18
Reported version
3.3
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
active
Regression
Yes
Workaround
No
Project

Load any score created with MS ver. 2.x and check the various elements of the "Format | Style... | Text styles" list: none has any offset value from the score.

I am attaching a 1-measure score created with ver. 2.3.2 in which each text style has been set to a rather unlikely (1.23, 1.23) offset.

If read with 3.x, none of the text styles has such an offset. Some have some offsets, which are presumably supplied arbitrarily by the programme.

Set to critical as it makes any work continuity with ver 2.x almost impossible.

Attachment Size
TestOffsetsTo3.mscx 12.73 KB

Comments

Ah, I saw the code above that where the tags themselves ("xoffset" and "yoffset") are processed, and I verified that code is hit. But this is indeed where it falls apart. Looks like that change was made during the beta period.

Maybe I'm missing something, but I don't think the series of tests for different styles should be needed any more. FWIW, I think all that code can probably be replaced by just the "case Pid::OFSET: value = offset; break;"

Seemed to work when I just tried it, although I didn't test very exhaustively.