Buttons are backwards on Apply new Styles dialog on Windows.
Reported version
3.x-dev
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
In windows programs the OK or accept button is on the left and the cancel or no button is on the right. I keep clicking the wrong button because they are backwards.
Fix version
3.6.0
Comments
This is a difference in defaults between Windows and macOS (not sure which order is used in Linux)
In the MacOS version of MuseScore there are related issues with Cancel button and OK button placement.
In the following dialogs MuseScore erroneously places OK on left & Cancel on right:
Edit>Instruments ...
Add>Measures>Append Measures ...
Add>Measures>Insert Measures ...
Style>Page Settings ...
In MacOS the OK button goes on the right.
This is important for the reason stated in the opening post: " I keep clicking the wrong button because they are backwards."
I was very clear to say this is on Windows. I didn't mention Linux which I'm not sure about and I know it's normal on Mac.
In reply to I was very clear to say this… by mike320
Yes. It was clear that your comments pertained to Windows.
I was pointing out where some of those errors are under MacOS so developers don't need to run a mine sweep.
It is generally happening when not using Qt's
QDialogButtonBox
, but 'manually' cobble together someQPushButton
without taking care of their order (in the same manual fashion), depending on OS.And indeed ' instrdialog.ui', 'measuresdialog.ui', 'insertmeasuresdialog.ui' and 'pagesettings.ui' do that (or rather don't). There are probably some more of those, like 'metaedit.ui'.
As is, in this case here, 'ScoreMigrationDialog.qml', which uses the
StyledButton
from '../palette/StyledButton.qml', as there is no(t yet a) 'StyledDialogButtonBox.qml'...It is not just Windows vs. Mac, vs. Linux though, but even in Linux it differs depending desktop environment, like KDE vs. Gnome, see https://doc.qt.io/qt-5/qdialogbuttonbox.html#ButtonLayout-enum
@scorster better open a new issue for the 5 UI files I mentioned
>> @scorster better open a new issue for the 5 UI files I mentioned
Done. Here's the link.
#314246: Some dialogs (under MacOS) have the Cancel and OK buttons reversed, right to left.
Better to name an issue as #314246: Some dialogs (under MacOS) have the Cancel and OK buttons reversed, right to left. ( type [#314246] )
Now the the other issue has this issue in the "What links here" section. It's not instantaneous but it does happen after a short period of time.
In reply to Better to name an issue as … by mike320
Thanks. Just updated my post accordingly.
PR created: https://github.com/musescore/MuseScore/pull/7121
Fixed in branch 3.x, commit 3d81e18c29
_Fix #314149: Order of buttons in ScoreMigrationDialog platform specific
By using QML's DialogButtonBox._
Automatically closed -- issue fixed for 2 weeks with no activity.