Adding instruments on top of others whose parts have been created leads to fatal corruption.

• Dec 30, 2020 - 07:40
Reported version
3.5
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project

OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.6.0.451380634, revision: 10dee08
And OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.6.0.452006856, revision: a8b24cf

I didn't check if it was a consequence of the fix of #313664: Reversing the order of the instruments after creating parts leads to very bad result (corruption/crashes), or some other aspect/scenario. That's why I'm opening a new issue

Steps to reproduce.

1) Treble clef template
2) Create parts (all parts)
3) "I" -> Add the Voice instrument
(note: automatically now, this Voice instrument is placed above the initial staff)
4) Enter some notes in the treble clef (Template)
5) Look at the part

Result: corruption, empty measures

piano.jpg

Note2: by choosing at step #1, the Piano template (two staves), we notice that at step #3, you have to move up manually the Voice instrument in the Instruments dialog.
In this case, with the same steps, the corruption occurs in the second staff (Bass clef) of the Piano.


Comments

Priority P0 - Critical

Confirmed indeed, and definitely critical. Note in my current build, voice actually gets added below existing treble staff / piano and doesn't show the problem, but flute gets added above and triggers it. Or, if I add voice then immediately move it up, same problem.

"Note in my current build, voice actually gets added below existing treble staff / piano and doesn't show the problem, but flute gets added above and triggers it"

Ok, I think in the first tests to have seen a random behavior - I was surprised sometimes - with these instrument additions (by click/Select + Add button , or directly double-click): sometimes the added instrument would go below, sometimes above (or maybe, it's different in 3.6 or branch master, no sure, more probably something else)
I'd have to take a closer look.
I'm not sure I can locate, because since the nightlies location change (http://ftp.osuosl.org/pub/musescore-nightlies/windows/), it's really weird, everything is mixed up. I haven't been following everything, and loaded very few nightlies lately.

Ah, I see a change (for now) between May 28 and June 24 (3.X) with steps:
1) Default score
2) Create part (all parts)
3) "I" -> Add Voice -> Move up this Voice above the initial staff default score
4) Enter notes in piano/default score staff
5) Look at the part: corruption, empty measures

I try to be more precise soon. EDIT: wow, between May 28 and June 10!

Nice job, backtracking it like this!
It's not 100% what I expected but you might be right. I'm on it (not yet, New Years Eve first :-)).

Status PR created fixed

Fixed in branch 3.x, commit cd2e93e506

_Fix #314935 - Adding instruments on top of others whose parts have been created leads to fatal corruption.

Rebuild the track mapping of the excerpts after any change in staves list._

Fix version
3.6.0