SECTION_BREAK on non-measure MEASURE_BASE does not incur pause before starting next section

• Aug 18, 2015 - 14:51
Type
Functional
Severity
S4 - Minor
Status
PR created
Project

This has a very similar cause to #73801: SECTION_BREAK on non-measure MEASURE_BASE does not reset measure numbering in next section, since I suspect the logic there is only looking at real measures as well. In this example, there should be a pause at all the red circles, but there isn't:

SECTION_BREAK on non-measure MeasureBase.png

Note: any fix for #32696: Section break causes pause before repeats will need to take the fact that SECTION_BREAKS can occur on frames into account as well. I'm self-assigning this bug, since I think I can fix it. I will probably cancel my pull request from a month ago https://github.com/musescore/MuseScore/pull/2133 since I was not even taking into account this as well. I think I can dramatically simplify the code for section break pauses once I fix #65161: Da Capo/Da Segno al Fine ignore next section on playback , since my fix there is breaking the repeat lists according to section breaks. I could then implement the "tick-shift" idea at the start of repeat lists that were after a section break.

Tested on my arch linux x86-64 selfbuilds and windows 32-bit 2.0.2 and 1229937 on x86-64 windows.

Attachment Size
SECTION_BREAK_on_frame.mscx 6.53 KB

Comments