Attaching grace note to first note of triplet corrupts score

I think this and #280547: tuplet brackets connected to two staves, moved up a staff, causing score corruption and crashes might be the same. I bet you can find the tuplet numbers - look a few staves down from where the actual tuplet is. It's not just grace notes, either. Copying a tuplet makes it go wonky. Pasting a tuplet goes wonky. Adding a staff and then some notes to it makes them go wonky.

I think it might be just anything that affects layout. I've also gotten duplicates of dynamics, lines, texts, hairpins on staves above the staff they're duplicating from.

I turned on the brackets on the tuplet and couldn't find it anywhere. I also looked in continuous view which sometimes makes it easier to find things. Still no triplet bracket in sight. Maybe it's the same, maybe not.

Came up again https://musescore.org/en/node/280696

I'm hitting this, too. Upon opening the file, I get the corruption notice, with the following detail

Measure 1, staff 1 incomplete. Expected: 3/4; Found: 21/24

Example file: triplets+grace_corruption.mscx

Seems to be easily repeatable (this trivial example file was built from scratch). Unfortunately, my 196 measure score is also corrupted in this way.

The title of this issue should really be changed--it's not just losing the "3" from the triplet--it's corrupting the score.

One related note: Using Cmd+Right to select the whole measure actually selects into the next measure. I guess this is just a symptom of the corruption.

Also, I think saving and reopening might be required to repro.

OS: macOS 10.14, Arch.: x86_64, MuseScore version (64-bit): 3.0.0.20137, revision: c1a5e4c

Steps from scratch:

• First scenario: single triplet/grace note (the "3" disappears after saving)

1) Load this test file: triplet.mscz
2) Attach a grace note to first note of triplet
3) Save/Exit
4) Reload
You get this result: the "3" is lost, but no corruption (file at this step: Grace triplet save.mscz)

• Second scenario: 2 triplets/grace note (results in corruption after saving)

1) Load the same test file, but after adding another triplet in the score, no matter where: 2 triplets.mscz
2) Add a grace note first note first triplet
3) Save/Exit
4) Restart
You get a corrupt score: Grace 2 triplets save.mscz

Another one: https://musescore.org/en/node/281124

Indeed critical.

Came up again in #281285: Loading Error.

All of the triplets in this issue to this point have been made up of quarter notes. In testing, I have found that tripets made of quarter and 16th notes lose their numbers as brackets when reloaded, but the beats in the measure are correct. I haven't tested, other tuplets or other note durations.

From what I see, when the tuplet and the grace notes are created, the grace notes are not added as elements of the tuplet, but only their parent notes. However, when the tuplet is read from the file, grace notes are also added to the list of its elements, as well as their parent notes; this could be the cause of the corruption.
I don't think it is possible to make a tuplet of grace notes, so maybe we could solve the bug by preventing a grace note to be added to a tuplet during file reading (the grace note would be added only to the parent note, which on the other hand is added to the tuplet, so no information lost should occur).

See https://github.com/musescore/MuseScore/pull/4546.

Fixed in branch master, commit 76aec8e639

fix #280640: Attaching grace note to first note of triplet corrupts score

Fixed in branch master, commit f7420a281f

Merge pull request #4546 from mattmcclinch/280640-tuplets-with-grace-notes

fix #280640: Attaching grace note to first note of triplet corrupts score

Automatically closed -- issue fixed for 2 weeks with no activity.